walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix copy-paste-error (#5444) 

This is a warning we found during static analyis with CodeSecure
CodeSonar.

It flagged a suspicious copy-paste error, where it finds code that seems
to have been copied from another location, with some, but not all,
variables substituted.

Unclear to me if this truly is a problem, or intentional, but I wanted
to provide the feedback as I am not sure how to test this.

Lines 5614 to 5619 in lib/symboldatabase.cpp are a copy from 5597-5602
with vartok replaced by valuetok, except for line 5616
This commit is contained in:
Mark Hermeling 2023-09-13 16:35:14 -04:00 committed by GitHub
parent a1078f446a
commit 6e6b3747fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/symboldatabase.cpp
View File

@ -5638,7 +5638,7 @@ const Function* Scope::findFunction(const Token *tok, bool requireConst) const
} }
const Token* valuetok = arguments[j]; const Token* valuetok = arguments[j];
if (valuetok->str() == "::") { if (valuetok->str() == "::") {
const Token* rml = nextAfterAstRightmostLeaf(vartok); const Token* rml = nextAfterAstRightmostLeaf(valuetok);
if (rml) if (rml)
valuetok = rml->previous(); valuetok = rml->previous();
} }