walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Removed more duplicate unit tests

This commit is contained in:
PKEuS 2013-04-13 02:07:18 -07:00
parent 78d3aef40e
commit 6f9886a1b9
1 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/teststl.cpp
View File

@ -107,7 +107,6 @@ private:
// Redundant conditions.. // Redundant conditions..
// if (ints.find(123) != ints.end()) ints.remove(123); // if (ints.find(123) != ints.end()) ints.remove(123);
TEST_CASE(redundantCondition1); TEST_CASE(redundantCondition1);
TEST_CASE(redundantCondition2);
// missing inner comparison when incrementing iterator inside loop // missing inner comparison when incrementing iterator inside loop
TEST_CASE(missingInnerComparison1); TEST_CASE(missingInnerComparison1);
@ -1658,15 +1657,6 @@ private:
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void redundantCondition1() {
check("void f(string haystack)\n"
"{\n"
" if (haystack.find(needle) != haystack.end())\n"
" haystack.remove(needle);"
"}");
ASSERT_EQUALS("[test.cpp:3]: (style) Redundant checking of STL container element existence before removing it.\n", errout.str());
}
void size2() { void size2() {
check("struct Fred {\n" check("struct Fred {\n"
" std::list<int> x;\n" " std::list<int> x;\n"
@ -1722,13 +1712,11 @@ private:
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void redundantCondition2() { void redundantCondition1() {
check("void f(string haystack)\n" check("void f(string haystack)\n"
"{\n" "{\n"
" if (haystack.find(needle) != haystack.end())\n" " if (haystack.find(needle) != haystack.end())\n"
" {\n" " haystack.remove(needle);"
" haystack.remove(needle);\n"
" }\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:3]: (style) Redundant checking of STL container element existence before removing it.\n", errout.str()); ASSERT_EQUALS("[test.cpp:3]: (style) Redundant checking of STL container element existence before removing it.\n", errout.str());
} }