From 6f9c115640825cc8641ac2ff502f65d670c64862 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Mon, 9 Apr 2018 08:00:11 +0200 Subject: [PATCH] Refactoring: use range for loops --- lib/preprocessor.cpp | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/lib/preprocessor.cpp b/lib/preprocessor.cpp index e0ee62d70..31a3b472d 100644 --- a/lib/preprocessor.cpp +++ b/lib/preprocessor.cpp @@ -100,8 +100,8 @@ static void inlineSuppressions(const simplecpp::TokenList &tokens, Settings &_se } // Add the suppressions. - for (std::list::const_iterator it = suppressionIDs.begin(); it != suppressionIDs.end(); ++it) { - _settings.nomsg.addSuppression(Suppressions::Suppression(*it, relativeFilename, tok->location.line)); + for (const std::string &errorId : suppressionIDs) { + _settings.nomsg.addSuppression(Suppressions::Suppression(errorId, relativeFilename, tok->location.line)); } suppressionIDs.clear(); } @@ -130,8 +130,8 @@ void Preprocessor::setDirectives(const simplecpp::TokenList &tokens) list.push_back(it->second); } - for (std::vector::const_iterator it = list.begin(); it != list.end(); ++it) { - for (const simplecpp::Token *tok = (*it)->cfront(); tok; tok = tok->next) { + for (const simplecpp::TokenList *tokenList : list) { + for (const simplecpp::Token *tok = tokenList->cfront(); tok; tok = tok->next) { if ((tok->op != '#') || (tok->previous && tok->previous->location.line == tok->location.line)) continue; if (tok->next && tok->next->str == "endfile") @@ -219,10 +219,10 @@ static std::string readcondition(const simplecpp::Token *iftok, const std::setstr); } std::string cfg; - for (std::set::const_iterator it = configset.begin(); it != configset.end(); ++it) { + for (const std::string &s : configset) { if (!cfg.empty()) cfg += ';'; - cfg += *it; + cfg += s; } return cfg; } @@ -250,16 +250,16 @@ static std::string cfg(const std::vector &configs, const std::strin { std::set configs2(configs.begin(), configs.end()); std::string ret; - for (std::set::const_iterator it = configs2.begin(); it != configs2.end(); ++it) { - if (it->empty()) + for (const std::string &cfg : configs2) { + if (cfg.empty()) continue; - if (*it == "0") + if (cfg == "0") return ""; - if (hasDefine(userDefines, *it)) + if (hasDefine(userDefines, cfg)) continue; if (!ret.empty()) ret += ';'; - ret += *it; + ret += cfg; } return ret; }