From 6fedbb4f773350adeb3b622b402fcd6cb079d2d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20St=C3=B6neberg?= Date: Mon, 19 Dec 2022 20:01:12 +0100 Subject: [PATCH] add/preserve `const` in `dynamic_cast` (#4655) --- gui/resultsview.cpp | 2 +- gui/statsdialog.cpp | 2 +- lib/checkbufferoverrun.cpp | 2 +- lib/checkclass.cpp | 2 +- lib/checknullpointer.cpp | 2 +- lib/checkuninitvar.cpp | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gui/resultsview.cpp b/gui/resultsview.cpp index 20066aeb3..a0e0e0b61 100644 --- a/gui/resultsview.cpp +++ b/gui/resultsview.cpp @@ -373,7 +373,7 @@ void ResultsView::readErrorsXml(const QString &filename) void ResultsView::updateDetails(const QModelIndex &index) { - QStandardItemModel *model = qobject_cast(mUI->mTree->model()); + const QStandardItemModel *model = qobject_cast(mUI->mTree->model()); QStandardItem *item = model->itemFromIndex(index); if (!item) { diff --git a/gui/statsdialog.cpp b/gui/statsdialog.cpp index 91bc24bf9..16ec8cb14 100644 --- a/gui/statsdialog.cpp +++ b/gui/statsdialog.cpp @@ -382,7 +382,7 @@ QChartView *StatsDialog::createChart(const QString &statsFile, const QString &to qreal maxY = 0; for (QAbstractSeries *s : chart->series()) { s->attachAxis(axisY); - if (QLineSeries *ls = dynamic_cast(s)) { + if (const QLineSeries *ls = dynamic_cast(s)) { for (QPointF p : ls->points()) { if (p.y() > maxY) maxY = p.y(); diff --git a/lib/checkbufferoverrun.cpp b/lib/checkbufferoverrun.cpp index 66ab48842..64a3b5a9c 100644 --- a/lib/checkbufferoverrun.cpp +++ b/lib/checkbufferoverrun.cpp @@ -960,7 +960,7 @@ bool CheckBufferOverrun::analyseWholeProgram(const CTU::FileInfo *ctu, const std const std::map> callsMap = ctu->getCallsMap(); for (Check::FileInfo *fi1 : fileInfo) { - const MyFileInfo *fi = dynamic_cast(fi1); + const MyFileInfo *fi = dynamic_cast(fi1); if (!fi) continue; for (const CTU::FileInfo::UnsafeUsage &unsafeUsage : fi->unsafeArrayIndex) diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp index b699a42c6..db036b91b 100644 --- a/lib/checkclass.cpp +++ b/lib/checkclass.cpp @@ -3199,7 +3199,7 @@ bool CheckClass::analyseWholeProgram(const CTU::FileInfo *ctu, const std::list all; for (Check::FileInfo *fi1 : fileInfo) { - const MyFileInfo *fi = dynamic_cast(fi1); + const MyFileInfo *fi = dynamic_cast(fi1); if (!fi) continue; for (const MyFileInfo::NameLoc &nameLoc : fi->classDefinitions) { diff --git a/lib/checknullpointer.cpp b/lib/checknullpointer.cpp index de51282e9..959bf014d 100644 --- a/lib/checknullpointer.cpp +++ b/lib/checknullpointer.cpp @@ -597,7 +597,7 @@ bool CheckNullPointer::analyseWholeProgram(const CTU::FileInfo *ctu, const std:: const std::map> callsMap = ctu->getCallsMap(); for (Check::FileInfo *fi1 : fileInfo) { - const MyFileInfo *fi = dynamic_cast(fi1); + const MyFileInfo *fi = dynamic_cast(fi1); if (!fi) continue; for (const CTU::FileInfo::UnsafeUsage &unsafeUsage : fi->unsafeUsage) { diff --git a/lib/checkuninitvar.cpp b/lib/checkuninitvar.cpp index 14c08e408..0d8e92e98 100644 --- a/lib/checkuninitvar.cpp +++ b/lib/checkuninitvar.cpp @@ -1703,7 +1703,7 @@ bool CheckUninitVar::analyseWholeProgram(const CTU::FileInfo *ctu, const std::li const std::map> callsMap = ctu->getCallsMap(); for (Check::FileInfo *fi1 : fileInfo) { - const MyFileInfo *fi = dynamic_cast(fi1); + const MyFileInfo *fi = dynamic_cast(fi1); if (!fi) continue; for (const CTU::FileInfo::UnsafeUsage &unsafeUsage : fi->unsafeUsage) {