From 7031cc7e221446c00968169eec8e10b5cd3a52b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= <daniel.marjamaki@gmail.com>
Date: Fri, 13 Apr 2018 22:19:47 +0200
Subject: [PATCH] misc.py: Add addon for some misc checkers

---
 addons/misc.py          | 72 +++++++++++++++++++++++++++++++++++++++++
 addons/test/misc-test.c |  4 +++
 2 files changed, 76 insertions(+)
 create mode 100644 addons/misc.py
 create mode 100644 addons/test/misc-test.c

diff --git a/addons/misc.py b/addons/misc.py
new file mode 100644
index 000000000..8e2f405b0
--- /dev/null
+++ b/addons/misc.py
@@ -0,0 +1,72 @@
+#!/usr/bin/env python
+#
+# Misc: Uncategorized checks that might be moved to some better addon later
+#
+# Example usage of this addon (scan a sourcefile main.cpp)
+# cppcheck --dump main.cpp
+# python misc.py main.cpp.dump
+
+import cppcheckdata
+import sys
+import re
+
+VERIFY = ('-verify' in sys.argv)
+VERIFY_EXPECTED = []
+VERIFY_ACTUAL = []
+
+def reportError(token, severity, msg, id):
+    if VERIFY:
+        VERIFY_ACTUAL.append(str(token.linenr) + ':' + id)
+    else:
+        sys.stderr.write(
+            '[' + token.file + ':' + str(token.linenr) + '] (' + severity + '): ' + msg + ' [' + id + ']\n')
+
+def simpleMatch(token, pattern):
+    for p in pattern.split(' '):
+        if not token or token.str != p:
+            return False
+        token = token.next
+    return True
+
+# check data
+def check(data):
+    arrayInit = False
+    for i in range(len(data.rawTokens)):
+        if i < 2:
+            continue
+        tok1 = data.rawTokens[i-2].str
+        tok2 = data.rawTokens[i-1].str
+        tok3 = data.rawTokens[i-0].str
+        if tok3 == '}':
+            arrayInit = False
+        elif tok1 == ']' and tok2 == '=' and tok3 == '{':
+            arrayInit = True
+        elif arrayInit and (tok1 in [',', '{']) and tok2.startswith('"') and tok3.startswith('"'):
+            reportError(data.rawTokens[i], 'style', 'string concatenation', 'stringConcatInArrayInit')
+
+for arg in sys.argv[1:]:
+    if arg == '-verify':
+        continue
+    print('Checking ' + arg + '...')
+    data = cppcheckdata.parsedump(arg)
+
+    if VERIFY:
+        VERIFY_ACTUAL = []
+        VERIFY_EXPECTED = []
+        for tok in data.rawTokens:
+            if tok.str.startswith('//'):
+                for word in tok.str[2:].split(' '):
+                    if word == 'stringConcatInArrayInit':
+                        VERIFY_EXPECTED.append(str(tok.linenr) + ':' + word)
+
+    check(data)
+
+    if VERIFY:
+        for expected in VERIFY_EXPECTED:
+            if expected not in VERIFY_ACTUAL:
+                print('Expected but not seen: ' + expected)
+                sys.exit(1)
+        for actual in VERIFY_ACTUAL:
+            if actual not in VERIFY_EXPECTED:
+                print('Not expected: ' + actual)
+                sys.exit(1)
diff --git a/addons/test/misc-test.c b/addons/test/misc-test.c
new file mode 100644
index 000000000..7739277f3
--- /dev/null
+++ b/addons/test/misc-test.c
@@ -0,0 +1,4 @@
+// To test:
+// ~/cppcheck/cppcheck --dump cert-test.c && python ../cert.py -verify cert-test.c.dump
+
+const char *a[] = {"a" "b"}; // stringConcatInArrayInit