From 72c9646be9c55d00b54694cc1df493a79bba5d36 Mon Sep 17 00:00:00 2001 From: Sebastian Date: Tue, 22 Jan 2019 07:28:29 +0100 Subject: [PATCH] misra.py: Possible fix for problematic code (#1613) Without the `for scope in data.scopes:` loop, scope is not assigned anything. From the context a loop over `data.scopes` could be intended. But other things like indentation would be possibly correct too. Not sure how this code should be. We try this fix. --- addons/misra.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/addons/misra.py b/addons/misra.py index 57da6d5b3..cc698ca57 100755 --- a/addons/misra.py +++ b/addons/misra.py @@ -731,11 +731,12 @@ class MisraChecker: self.reportError(scope.bodyStart, 5, 3) for e in enum: - if scope.className and innerVar.nameToken.str[:31] == e[:31]: - if int(innerVar.nameToken.linenr) > int(innerScope.bodyStart.linenr): - self.reportError(innerVar.nameToken, 5, 3) - else: - self.reportError(innerScope.bodyStart, 5, 3) + for scope in data.scopes: + if scope.className and innerVar.nameToken.str[:31] == e[:31]: + if int(innerVar.nameToken.linenr) > int(innerScope.bodyStart.linenr): + self.reportError(innerVar.nameToken, 5, 3) + else: + self.reportError(innerScope.bodyStart, 5, 3) for e in enum: for scope in data.scopes: if scope.className and scope.className[:31] == e[:31]: