From 744b3631861d510abde174dee88c83359b178dc0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Sat, 18 Jul 2020 08:23:04 +0200 Subject: [PATCH] GUI; Tweaks. Add tooltips, change texts. --- gui/projectfiledialog.cpp | 5 +-- gui/projectfiledialog.ui | 39 ++++++++++++++++++---- gui/resultsview.ui | 69 +++++++++++++++------------------------ 3 files changed, 62 insertions(+), 51 deletions(-) diff --git a/gui/projectfiledialog.cpp b/gui/projectfiledialog.cpp index 4eb1c403d..52ce8c61e 100644 --- a/gui/projectfiledialog.cpp +++ b/gui/projectfiledialog.cpp @@ -208,6 +208,7 @@ ProjectFileDialog::ProjectFileDialog(ProjectFile *projectFile, QWidget *parent) connect(mUI.mListSuppressions, &QListWidget::doubleClicked, this, &ProjectFileDialog::editSuppression); connect(mUI.mBtnBrowseMisraFile, &QPushButton::clicked, this, &ProjectFileDialog::browseMisraFile); connect(mUI.mChkAllVsConfigs, &QCheckBox::clicked, this, &ProjectFileDialog::checkAllVSConfigs); + connect(mUI.mBtnNormalAnalysis, &QCheckBox::toggled, mUI.mBtnSafeClasses, &QCheckBox::setEnabled); loadFromProjectFile(projectFile); } @@ -266,7 +267,7 @@ void ProjectFileDialog::loadFromProjectFile(const ProjectFile *projectFile) else mUI.mBtnCppcheckParser->setChecked(true); mUI.mBtnSafeClasses->setChecked(projectFile->safeChecks.classes); - mUI.mBugHunting->setChecked(projectFile->bugHunting); + mUI.mBtnBugHunting->setChecked(projectFile->bugHunting); setExcludedPaths(projectFile->getExcludedPaths()); setLibraries(projectFile->getLibraries()); const QString platform = projectFile->getPlatform(); @@ -371,7 +372,7 @@ void ProjectFileDialog::saveToProjectFile(ProjectFile *projectFile) const projectFile->setLibraries(getLibraries()); projectFile->clangParser = mUI.mBtnClangParser->isChecked(); projectFile->safeChecks.classes = mUI.mBtnSafeClasses->isChecked(); - projectFile->bugHunting = mUI.mBugHunting->isChecked(); + projectFile->bugHunting = mUI.mBtnBugHunting->isChecked(); if (mUI.mComboBoxPlatform->currentText().endsWith(".xml")) projectFile->setPlatform(mUI.mComboBoxPlatform->currentText()); else { diff --git a/gui/projectfiledialog.ui b/gui/projectfiledialog.ui index 1cf6d5d15..d809dd894 100644 --- a/gui/projectfiledialog.ui +++ b/gui/projectfiledialog.ui @@ -420,7 +420,11 @@ - + + + This is a workfolder that Cppcheck will use for various purposes. + + @@ -461,18 +465,31 @@ - Check that code is safe + Analysis - + - Bug hunting -- Detect all bugs. Generates mostly noise. + Normal analysis -- Avoid false positives. + + + true + + + + + + + Bug hunting -- Generates mostly noise. The goal is to be "soundy" and detect most bugs. + + If you want to design your classes to be as flexible and robust as possible then the public interface must be very robust. Cppcheck will asumme that arguments can take *any* value. + Check that each class has a safe public interface @@ -605,7 +622,11 @@ - + + + Filepaths in warnings will be relative to this path + + @@ -617,7 +638,11 @@ - + + + If tags are added, you will be able to right click on warnings and set one of these tags. You can manually categorize warnings. + + @@ -625,7 +650,7 @@ - Exclude source files in paths + Exclude source files diff --git a/gui/resultsview.ui b/gui/resultsview.ui index 584c8a9ea..cfe8b57d5 100644 --- a/gui/resultsview.ui +++ b/gui/resultsview.ui @@ -159,49 +159,34 @@ - - - Qt::Vertical + + + Configured contracts: + + + + + + + QAbstractItemView::NoEditTriggers + + + + + + + Missing contracts: + + + + + + + QAbstractItemView::NoEditTriggers + + + true - - - - - - Configured contracts: - - - - - - - QAbstractItemView::NoEditTriggers - - - - - - - - - - - Missing contracts: - - - - - - - QAbstractItemView::NoEditTriggers - - - true - - - - -