walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #10218 (FP uninitvar with input from stringstream in for loop)

This commit is contained in:
Daniel Marjamäki 2021-05-10 19:48:07 +02:00
parent db7be3e91b
commit 75311fba0f
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/astutils.cpp
View File

@ -2213,7 +2213,7 @@ bool isLikelyStreamRead(bool cpp, const Token *op)
const Token *parent = op; const Token *parent = op;
while (parent->astParent() && parent->astParent()->str() == op->str()) while (parent->astParent() && parent->astParent()->str() == op->str())
parent = parent->astParent(); parent = parent->astParent();
if (parent->astParent() && !Token::Match(parent->astParent(), "%oror%|&&|(|,|.|!")) if (parent->astParent() && !Token::Match(parent->astParent(), "%oror%|&&|(|,|.|!|;"))
return false; return false;
if (op->str() == "&" && parent->astParent()) if (op->str() == "&" && parent->astParent())
return false; return false;

10
test/testuninitvar.cpp
View File

@ -71,6 +71,7 @@ private:
TEST_CASE(uninitvar9); // ticket #6424 TEST_CASE(uninitvar9); // ticket #6424
TEST_CASE(uninitvar10); // ticket #9467 TEST_CASE(uninitvar10); // ticket #9467
TEST_CASE(uninitvar11); // ticket #9123 TEST_CASE(uninitvar11); // ticket #9123
TEST_CASE(uninitvar12); // #10218 - stream read
TEST_CASE(uninitvar_unconditionalTry); TEST_CASE(uninitvar_unconditionalTry);
TEST_CASE(uninitvar_funcptr); // #6404 TEST_CASE(uninitvar_funcptr); // #6404
TEST_CASE(uninitvar_operator); // #6680 TEST_CASE(uninitvar_operator); // #6680
@ -2773,6 +2774,15 @@ private:
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void uninitvar12() { // 10218
const char code[] = "void fp() {\n"
" std::stringstream ss;\n"
" for (int i; ss >> i;) {}\n"
"}";
checkUninitVar(code);
ASSERT_EQUALS("", errout.str());
}
void uninitvar_unconditionalTry() { void uninitvar_unconditionalTry() {
// Unconditional scopes and try{} scopes // Unconditional scopes and try{} scopes
checkUninitVar("int f() {\n" checkUninitVar("int f() {\n"