walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Merge pull request #584 from Dmitry-Me/betterVariableName3 

Formatting cleanup, better variable name
This commit is contained in:
amai2012 2015-04-02 09:20:31 +02:00
parent 111bcb1b87 7b69396223
commit 788da37e05
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/checkassert.cpp
View File

@ -108,17 +108,18 @@ void CheckAssert::assignmentInAssertError(const Token *tok, const std::string& v
// checks if side effects happen on the variable prior to tmp
void CheckAssert::checkVariableAssignment(const Token* assignTok)
{
const Variable* v = assignTok->previous()->variable();
if (!v) return;
const Variable* prevVar = assignTok->previous()->variable();
if (!prevVar)
return;
// assignment
if (assignTok->isAssignmentOp() || assignTok->type() == Token::eIncDecOp) {
if (prevVar->isConst())
return;
if (v->isConst()) return;
assignmentInAssertError(assignTok, v->name());
assignmentInAssertError(assignTok, prevVar->name());
}
// TODO: function calls on v
// TODO: function calls on prevVar
}
bool CheckAssert::inSameScope(const Token* returnTok, const Token* assignTok)