walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Simplified TestBufferOverrun test cases (sizeof, known variable value)

This commit is contained in:
Daniel Marjamäki 2013-04-13 11:01:19 +02:00
parent 693c6e84cb
commit 78d3aef40e
1 changed files with 11 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
test/testbufferoverrun.cpp
View File

@ -1962,13 +1962,11 @@ private:
} }
void array_index_string_literal() { void array_index_string_literal() {
check("void f()\n" check("void f() {\n"
"{\n"
" const char *str = \"abc\";\n" " const char *str = \"abc\";\n"
" int i = 10;\n" " bar(str[10]);\n"
" bar(str[i]);\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:5]: (error) Array 'str[4]' accessed at index 10, which is out of bounds.\n", errout.str()); ASSERT_EQUALS("[test.cpp:3]: (error) Array 'str[4]' accessed at index 10, which is out of bounds.\n", errout.str());
check("void f()\n" check("void f()\n"
"{\n" "{\n"
@ -2054,14 +2052,14 @@ private:
check("void f(FILE* fd)\n" check("void f(FILE* fd)\n"
"{\n" "{\n"
"char str[3];\n" "char str[3];\n"
"fread(str,sizeof(char),4,fd);\n" "fread(str,1,4,fd);\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:4]: (error) Buffer is accessed out of bounds: str\n", errout.str()); ASSERT_EQUALS("[test.cpp:4]: (error) Buffer is accessed out of bounds: str\n", errout.str());
check("void f(FILE* fd)\n" check("void f(FILE* fd)\n"
"{\n" "{\n"
"char str[3*sizeof(char)];\n" "char str[3];\n"
"fread(str,sizeof(char),3,fd);\n" "fread(str,1,3,fd);\n"
"}"); "}");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
@ -2069,14 +2067,14 @@ private:
check("void f(FILE* fd)\n" check("void f(FILE* fd)\n"
"{\n" "{\n"
"char str[3];\n" "char str[3];\n"
"fwrite(str,sizeof(char),4,fd);\n" "fwrite(str,1,4,fd);\n"
"}"); "}");
ASSERT_EQUALS("[test.cpp:4]: (error) Buffer is accessed out of bounds: str\n", errout.str()); ASSERT_EQUALS("[test.cpp:4]: (error) Buffer is accessed out of bounds: str\n", errout.str());
check("void f(FILE* fd)\n" check("void f(FILE* fd)\n"
"{\n" "{\n"
"char str[3*sizeof(char)];\n" "char str[3];\n"
"fwrite(str,sizeof(char),3,fd);\n" "fwrite(str,1,3,fd);\n"
"}"); "}");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
@ -2389,7 +2387,7 @@ private:
check("void f(char *a) {\n" check("void f(char *a) {\n"
" char *b = malloc(strlen(a));\n" " char *b = malloc(strlen(a));\n"
" if (1) {\n" " {\n"
" strcpy(b, a);\n" " strcpy(b, a);\n"
" }\n" " }\n"
" return b;\n" " return b;\n"
@ -2454,7 +2452,7 @@ private:
check("extern char a[10];\n" check("extern char a[10];\n"
"void f() {\n" "void f() {\n"
" char b[25] = {0};\n" " char b[25] = {0};\n"
" std::memcpy(b, a, sizeof(a));\n" " std::memcpy(b, a, 10);\n"
"}"); "}");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }