walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

misra: Fixed crash with struct fields with unknown types on 9.x rules (#3305) 

This fixes the crash on with struct fields containing unknown types
reported on the forum:
https://sourceforge.net/p/cppcheck/discussion/general/thread/d64551cc55/#5f0f

The suggested patch doesn't handle the cases when there are struct
fields with arrays containing unknown types. So the addon will not
generate warnings in these cases. The problem is that Cppcheck doesn't
generate valueType-pointer information for unknown types in the dump
file. When adding this in symboldatabase.cpp, MISRA addon will generate
a lot of false positives because we depend on the null value of
valueType.

So I suppose it better to left this as is, to don't break the addon for
such rare cases.
This commit is contained in:
Georgiy Komarov 2021-06-24 09:29:27 +03:00 committed by GitHub
parent b13e44fce5
commit 79f59d8f39
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
addons/misra_9.py
View File

@ -303,7 +303,7 @@ class InitializerParser:
if isFirstElement and self.token.str == '0' and self.token.next.str == '}': if isFirstElement and self.token.str == '0' and self.token.next.str == '}':
# Zero initializer causes recursive initialization # Zero initializer causes recursive initialization
self.root.initializeChildren() self.root.initializeChildren()
elif self.token.isString and self.ed.valueType.pointer > 0: elif self.token.isString and self.ed.valueType and self.ed.valueType.pointer > 0:
if self.ed.valueType.pointer - self.ed.getEffectiveLevel() == 1: if self.ed.valueType.pointer - self.ed.getEffectiveLevel() == 1:
if self.ed.parent != self.root: if self.ed.parent != self.root:
self.root.markStuctureViolation(self.token) self.root.markStuctureViolation(self.token)

19
addons/test/misra/misra-test.c
View File

@ -432,6 +432,12 @@ void misra_9_struct_initializers(void) {
struct1 s[2][2]; struct1 s[2][2];
} struct3; } struct3;
typedef struct {
unknown_field_type f1;
unknown_field_type f2[2];
int f3[2];
} struct_with_unknown_fields;
struct3 sa[2] = { [1].s[1][0].i1 = 3, 4 }; // 9.2 struct3 sa[2] = { [1].s[1][0].i1 = 3, 4 }; // 9.2
struct1 sa = 1; // 9.2 struct1 sa = 1; // 9.2
@ -483,6 +489,19 @@ void misra_9_struct_initializers(void) {
dummy_struct dsg = { .a = {0}, .b = {0} }; dummy_struct dsg = { .a = {0}, .b = {0} };
dummy_struct dsh[2][2] = { { {.a = 0, .b = {0}}, { 0 } }, { { 0 }, {.a = 0, .b = {0}}} }; dummy_struct dsh[2][2] = { { {.a = 0, .b = {0}}, { 0 } }, { { 0 }, {.a = 0, .b = {0}}} };
// Struct with fields of unknown type
struct_with_unknown_fields ufa = { 1, { 1, 2 }, { 1, 2 } };
struct_with_unknown_fields ufb = { 1, 1, 2 }; // 9.2
struct_with_unknown_fields[2] ufc = { {1, { 1, 2 }, { 1, 2 } },
{ 2, { 1, 2 }, { 1, 2 } } };
struct_with_unknown_fields[2][2] ufd = { {1, { 1, 2 }, { 1, 2 } },
{ 2, { 1, 2 }, { 1, 2 } } };
struct_with_unknown_fields[2] ufe = { 1, { 1, 2 }, { 1, 2 }, // TODO: 9.2
2, { 1, 2 }, { 1, 2 } };
struct_with_unknown_fields[3] uff = { { 1, { 1, 2 }, { 1, 2 }}, // TODO: 9.3 9.4
{2, { 1, 2 }, { 1, 2 }},
[1] = { 2, { 1, 2 }, { 1, 2 }} };
// Obsolete initialization syntax for GCC // Obsolete initialization syntax for GCC
struct1 os1 = { i1: 1, i2: 2 }; // 10.4 13.4 struct1 os1 = { i1: 1, i2: 2 }; // 10.4 13.4
} }