walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Always pass unsigned char to ::isspace to prevent runtime error in MSVC

This commit is contained in:
Greg Hewgill 2011-03-07 07:50:48 +13:00
parent de31ec1e44
commit 7daa6b9370
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/preprocessor.cpp
View File

@ -307,7 +307,13 @@ static bool isFallThroughComment(std::string comment)
{
// convert comment to lower case without whitespace
std::transform(comment.begin(), comment.end(), comment.begin(), ::tolower);
comment.erase(std::remove_if(comment.begin(), comment.end(), ::isspace), comment.end());
for (std::string::iterator i = comment.begin(); i != comment.end(); )
{
if (::isspace(static_cast<unsigned char>(*i)))
comment.erase(i);
else
++i;
}
return comment.find("fallthr") != std::string::npos ||
comment.find("fallsthr") != std::string::npos ||