walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Detects invalid iterator inside for() when postfix form of increment used.

This commit is contained in:
Slava Semushin 2009-09-27 15:10:21 +07:00
parent 5285635354
commit 7e2208b5cc
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/checkstl.cpp
View File

@ -318,7 +318,7 @@ void CheckStl::pushback()
tok2 = tok2->tokAt(2); tok2 = tok2->tokAt(2);
} }
if (Token::Match(tok2, "%varid% = %var% . begin ( ) ; %varid% != %var% . end ( ) ; ++ %varid% ) {", iteratorid)) if (Token::Match(tok2, "%varid% = %var% . begin ( ) ; %varid% != %var% . end ( ) ; ++| %varid% ++| ) {", iteratorid))
{ {
const unsigned int vectorid(tok2->tokAt(2)->varId()); const unsigned int vectorid(tok2->tokAt(2)->varId());
if (vectorid == 0) if (vectorid == 0)

16
test/teststl.cpp
View File

@ -57,6 +57,7 @@ private:
TEST_CASE(pushback4); TEST_CASE(pushback4);
TEST_CASE(pushback5); TEST_CASE(pushback5);
TEST_CASE(pushback6); TEST_CASE(pushback6);
TEST_CASE(pushback7);
TEST_CASE(insert1); TEST_CASE(insert1);
@ -421,6 +422,21 @@ private:
ASSERT_EQUALS("[test.cpp:9]: (error) After push_back or push_front, the iterator 'it' may be invalid\n", errout.str()); ASSERT_EQUALS("[test.cpp:9]: (error) After push_back or push_front, the iterator 'it' may be invalid\n", errout.str());
} }
void pushback7()
{
check("void f()\n"
"{\n"
" std::vector<int> foo;\n"
" foo.push_back(10);\n"
" std::vector<int>::iterator it;\n"
" for (it = foo.begin(); it != foo.end(); it++)\n"
" {\n"
" foo.push_back(123);\n"
" }\n"
"}\n");
ASSERT_EQUALS("[test.cpp:8]: (error) After push_back or push_front, the iterator 'it' may be invalid\n", errout.str());
}
void insert1() void insert1()
{ {