walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Extract repeating checks, break loop early

This commit is contained in:
Dmitry-Me 2017-09-05 00:04:48 +03:00
parent 79f74fc4d3
commit 7e823e6d8e
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/checkclass.cpp
View File

@ -402,11 +402,15 @@ bool CheckClass::canNotCopy(const Scope *scope)
for (func = scope->functionList.begin(); func != scope->functionList.end(); ++func) { for (func = scope->functionList.begin(); func != scope->functionList.end(); ++func) {
if (func->isConstructor()) if (func->isConstructor())
constructor = true; constructor = true;
if ((func->type == Function::eCopyConstructor) && if (func->access != Public)
func->access == Public) continue;
if (func->type == Function::eCopyConstructor) {
publicCopy = true; publicCopy = true;
else if (func->type == Function::eOperatorEqual && func->access == Public) break;
} else if (func->type == Function::eOperatorEqual) {
publicAssign = true; publicAssign = true;
break;
}
} }
return constructor && !(publicAssign || publicCopy); return constructor && !(publicAssign || publicCopy);