Fixed #673 (False positive: null pointer dereference when dynamic cast is used)

src/checkother.h

@@ -52,6 +52,7 @@ public:
             checkOther.warningOldStylePointerCast();
             checkOther.checkUnsignedDivision();
             checkOther.checkCharVariable();
+            checkOther.nullPointer();
         }
     }
 
@@ -75,7 +76,6 @@ public:
 
         checkOther.strPlusChar();
         checkOther.invalidFunctionUsage();
-        checkOther.nullPointer();
         checkOther.checkZeroDivision();
     }
 

src/tokenize.cpp

@@ -499,6 +499,8 @@ bool Tokenizer::tokenize(std::istream &code, const char FileName[])
         }
     }
 
+    setVarId();
+
     return true;
 }
 //---------------------------------------------------------------------------

test/testother.cpp

@@ -519,8 +519,6 @@ private:
         Tokenizer tokenizer;
         std::istringstream istr(code);
         tokenizer.tokenize(istr, "test.cpp");
-        tokenizer.simplifyTokenList();
-        tokenizer.setVarId();
 
         // Clear the error buffer..
         errout.str("");
@@ -669,6 +667,15 @@ private:
                          "    while (a > 0);\n"
                          "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        // dynamic_cast..
+        checkNullPointer("void foo(ABC *abc)\n"
+                         "{\n"
+                         "    int a = abc->a;\n"
+                         "    if (!dynamic_cast<DEF *>(abc))\n"
+                         "        ;\n"
+                         "}\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     // Dereferencing a pointer and then checking if it is null