walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix autovarInvalidDeallocation regression (#5203)

This commit is contained in:
chrchr-github 2023-06-29 07:42:53 +02:00 committed by GitHub
parent 1b4ec0def4
commit 818ebb8d7e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkautovariables.cpp
View File

@ -303,7 +303,7 @@ void CheckAutoVariables::autoVariables()
if (v.isImpossible()) if (v.isImpossible())
continue; continue;
if ((v.isTokValue() && (isArrayVar(v.tokvalue) || ((v.tokvalue->tokType() == Token::eString)))) || if ((v.isTokValue() && (isArrayVar(v.tokvalue) || ((v.tokvalue->tokType() == Token::eString)))) ||
(v.isLocalLifetimeValue() && v.lifetimeKind == ValueFlow::Value::LifetimeKind::Address)) { (v.isLocalLifetimeValue() && v.lifetimeKind == ValueFlow::Value::LifetimeKind::Address && !Token::simpleMatch(v.tokvalue, "("))) {
errorInvalidDeallocation(tok, &v); errorInvalidDeallocation(tok, &v);
break; break;
} }

6
test/testautovariables.cpp
View File

@ -847,6 +847,12 @@ private:
" return 0;\n" " return 0;\n"
"}\n"); "}\n");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
check("void f() {\n"
" S* p = &g();\n"
" delete p;\n"
"}\n");
ASSERT_EQUALS("", errout.str());
} }
void testinvaliddealloc_input() { void testinvaliddealloc_input() {