walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

MISRA 10.4 - fixed ?: operator (#1281) 

x ? a : b - only a and b has to be checked
This commit is contained in:
Konrad Grochowski 2018-06-09 08:23:41 +02:00 committed by Daniel Marjamäki
parent db7d267c02
commit 8290d84472
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
addons/misra.py
View File

@ -781,7 +781,7 @@ def misra_10_1(data):
reportError(token, 10, 1) reportError(token, 10, 1)
def misra_10_4(data): def misra_10_4(data):
op = {'+', '-', '*', '/', '%', '&', '|', '^', '+=', '-=', '?', ':'} op = {'+', '-', '*', '/', '%', '&', '|', '^', '+=', '-=', ':'}
for token in data.tokenlist: for token in data.tokenlist:
if token.str not in op and not token.isComparisonOp: if token.str not in op and not token.isComparisonOp:
continue continue

4
addons/test/misra-test.c
View File

@ -153,13 +153,15 @@ void misra_10_1() {
void misra_10_4(u32 x, s32 y) { void misra_10_4(u32 x, s32 y) {
z = x + 3; // 10.4 z = x + 3; // 10.4
enum misra_10_4_enuma { misra_10_4_A1, misra_10_4_A2, misra_10_4_A3 }; enum misra_10_4_enuma { misra_10_4_A1, misra_10_4_A2, misra_10_4_A3 } a;
enum misra_10_4_enumb { misra_10_4_B1, misra_10_4_B2, misra_10_4_B3 }; enum misra_10_4_enumb { misra_10_4_B1, misra_10_4_B2, misra_10_4_B3 };
if ( misra_10_4_B1 > misra_10_4_A1 ) //10.4 if ( misra_10_4_B1 > misra_10_4_A1 ) //10.4
{ {
; ;
} }
z = x + y; //10.4 z = x + y; //10.4
z = (a == misra_10_4_A3) ? x : y; //10.4
z = (a == misra_10_4_A3) ? y : y; // no-warning
} }
void misra_10_6(u8 x, u32 a, u32 b) { void misra_10_6(u8 x, u32 a, u32 b) {