From 82bdbcd73bd7f9d5ec22bbcd9267536c93aa6aca Mon Sep 17 00:00:00 2001
From: Paul Fultz II <pfultz2@yahoo.com>
Date: Fri, 28 Aug 2020 12:26:09 -0500
Subject: [PATCH] Fix issue 9859: false positive: knownConditionTrueFalse
 (#2759)

---
 lib/valueflow.cpp      |  2 +-
 test/testcondition.cpp | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
index 6f2a2defe..0dcd77418 100644
--- a/lib/valueflow.cpp
+++ b/lib/valueflow.cpp
@@ -2574,7 +2574,7 @@ struct SingleValueFlowForwardAnalyzer : ValueFlowForwardAnalyzer {
     virtual bool isGlobal() const OVERRIDE {
         for (const auto&p:getVars()) {
             const Variable* var = p.second;
-            if (var->isGlobal() && !var->isConst())
+            if (!var->isLocal() && !var->isArgument() && !var->isConst())
                 return true;
         }
         return false;
diff --git a/test/testcondition.cpp b/test/testcondition.cpp
index 871e93c5a..b641a7ec0 100644
--- a/test/testcondition.cpp
+++ b/test/testcondition.cpp
@@ -3588,6 +3588,17 @@ private:
               "        return;\n"
               "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        check("struct A {\n"
+              "    std::vector<int> v;\n"
+              "    void g();\n"
+              "    void f(bool b) {\n"
+              "        v.clear();\n"
+              "        g();\n"
+              "        return !v.empty();\n"
+              "    }\n"
+              "};\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void multiConditionAlwaysTrue() {