walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix #10545 FP redundantCopyLocalConst with modified object [inconclusive] (#4197) 

* Fix  #10545 FP redundantCopyLocalConst with modified object [inconclusive]

* Comment
This commit is contained in:
chrchr-github 2022-06-11 11:01:23 +02:00 committed by GitHub
parent 653a1ea83e
commit 8579feb3aa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/checkother.cpp
View File

@ -2757,6 +2757,10 @@ void CheckOther::checkRedundantCopy()
if (!Token::Match(tok->link(), ") )| ;")) // bailout for usage like "const A a = getA()+3" if (!Token::Match(tok->link(), ") )| ;")) // bailout for usage like "const A a = getA()+3"
continue; continue;
const Token* dot = tok->astOperand1();
if (Token::simpleMatch(dot, ".") && dot->astOperand1() && isVariableChanged(dot->astOperand1()->variable(), mSettings, mTokenizer->isCPP()))
continue;
const Function* func = tok->previous()->function(); const Function* func = tok->previous()->function();
if (func && func->tokenDef->strAt(-1) == "&") { if (func && func->tokenDef->strAt(-1) == "&") {
redundantCopyError(startTok, startTok->str()); redundantCopyError(startTok, startTok->str());

15
test/testother.cpp
View File

@ -7521,7 +7521,7 @@ private:
" }\n" " }\n"
"}"; "}";
check(code5618, nullptr, false, true); check(code5618, nullptr, false, true);
TODO_ASSERT_EQUALS("", "[test.cpp:7]: (performance, inconclusive) Use const reference for 'temp' to avoid unnecessary data copying.\n", errout.str()); ASSERT_EQUALS("", errout.str());
check(code5618, nullptr, false, false); check(code5618, nullptr, false, false);
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
@ -7544,6 +7544,19 @@ private:
" const CD cd(CD::getOne());\n" " const CD cd(CD::getOne());\n"
"}", nullptr, false, true); "}", nullptr, false, true);
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
check("struct S {\n" // #10545
" int modify();\n"
" const std::string& get() const;\n"
"};\n"
"std::string f(S& s) {\n"
" const std::string old = s.get();\n"
" int i = s.modify();\n"
" if (i != 0)\n"
" return old;\n"
" return {};\n"
"}", nullptr, /*experimental*/ false, /*inconclusive*/ true);
ASSERT_EQUALS("", errout.str());
} }
void checkNegativeShift() { void checkNegativeShift() {