From 870b8b9c608de8a71a33c0351e098e093aea4e27 Mon Sep 17 00:00:00 2001 From: orbitcowboy Date: Mon, 30 Aug 2021 11:07:38 +0200 Subject: [PATCH] misra.py: Fixed FN for rule 21.8 --- addons/misra.py | 2 +- addons/test/misra/misra-test.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/addons/misra.py b/addons/misra.py index 997585261..28f4c27ea 100755 --- a/addons/misra.py +++ b/addons/misra.py @@ -3451,7 +3451,7 @@ class MisraChecker: def misra_21_8(self, data): for token in data.tokenlist: - if isFunctionCall(token) and (token.astOperand1.str in ('abort', 'exit', 'getenv')): + if isFunctionCall(token) and (token.astOperand1.str in ('abort', 'exit', 'getenv', 'system')): self.reportError(token, 21, 8) def misra_21_9(self, data): diff --git a/addons/test/misra/misra-test.c b/addons/test/misra/misra-test.c index a3080d611..338a8f371 100644 --- a/addons/test/misra/misra-test.c +++ b/addons/test/misra/misra-test.c @@ -1768,6 +1768,7 @@ static void misra_21_7(void) { static void misra_21_8(void) { abort(); // 21.8 (void)getenv("foo"); // 21.8 + (void)system("cmd"); // 21.8 exit(-1); // 21.8 }