walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Uninitialized variables; Fixed FP in valueflow-based checking

This commit is contained in:
Daniel Marjamäki 2021-05-23 18:43:34 +02:00
parent f968761382
commit 8ad0905e3b
2 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/checkuninitvar.cpp
View File

@ -1532,8 +1532,12 @@ void CheckUninitVar::valueFlowUninit()
const bool isarray = !tok->variable() || tok->variable()->isArray();
const bool ispointer = astIsPointer(tok) && !isarray;
const bool deref = CheckNullPointer::isPointerDeRef(tok, unknown, mSettings);
if (ispointer && v->indirect == 1 && !deref)
if (ispointer && !deref) {
if (v->indirect >= 1)
continue;
if (!isVariableUsage(tok, true, NO_ALLOC, 0))
continue;
}
if (isarray && !deref)
continue;
uninitderef = deref && v->indirect == 0;

14
test/testuninitvar.cpp
View File

@ -4474,14 +4474,12 @@ private:
"}");
ASSERT_EQUALS("", errout.str());
valueFlowUninit("int a(FArchive &arc) {\n"
valueFlowUninit("int a(FArchive &arc) {\n" // #3060 (initialization through operator<<)
" int *p;\n"
" arc << p;\n"
" return *p;\n"
" return *p;\n" // fp: should not warn
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: p\n"
"[test.cpp:4]: (error) Uninitialized variable: p\n",
errout.str());
TODO_ASSERT_EQUALS("", "[test.cpp:4]: (error) Uninitialized variable: p\n", errout.str());
// #4320
valueFlowUninit("void f() {\n"
@ -4603,6 +4601,12 @@ private:
"}");
ASSERT_EQUALS("", errout.str());
valueFlowUninit("void foo(struct qb_list_head *list) {\n"
" struct qb_list_head *iter;\n"
" qb_list_for_each(iter, list) {}\n"
"}\n");
ASSERT_EQUALS("", errout.str());
valueFlowUninit("int foo()\n"
"{\n"
" int i;\n"