From 8cbafe3efec4771be99ce04ffd2fb1b87f7fafcb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= Date: Sat, 23 Aug 2008 16:50:29 +0000 Subject: [PATCH] test: Added 'testdivision.cpp' --- testdivision.cpp | 68 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 testdivision.cpp diff --git a/testdivision.cpp b/testdivision.cpp new file mode 100644 index 000000000..1f5722133 --- /dev/null +++ b/testdivision.cpp @@ -0,0 +1,68 @@ + +// Check for dangerous division.. +// such as "svar / uvar". Treating "svar" as unsigned data is not good + + +#include "tokenize.h" +#include "CheckOther.h" +#include "MiniCppUnit.h" + +#include + +extern std::ostringstream errout; +extern bool ShowAll; +extern bool CheckCodingStyle; + +class TestDivision : public TestFixture +{ +private: + void check( const char code[] ) + { + // Tokenize.. + tokens = tokens_back = NULL; + std::istringstream istr(code); + TokenizeCode( istr ); + //SimplifyTokenList(); <- this can't be used as it removes 'unsigned' + + // Clear the error buffer.. + errout.str(""); + + // Check for memory leaks.. + CheckCodingStyle = true; + ShowAll = true; + CheckUnsignedDivision(); + } + +public: + TEST_FIXTURE( TestDivision ) + { + TEST_CASE( division1 ); + TEST_CASE( division2 ); + } + + void division1() + { + check( "void f()\n" + "{\n" + " int ivar = -2;\n" + " unsigned int uvar = 2;\n" + " return ivar / uvar;\n" + "}\n" ); + ASSERT_EQUALS( std::string("[test.cpp:5]: If the result is negative it will be wrong because an operand is unsigned.\n"), errout.str() ); + } + + void division2() + { + check( "void f()\n" + "{\n" + " int ivar = -2;\n" + " unsigned int uvar = 2;\n" + " return uvar / ivar;\n" + "}\n" ); + ASSERT_EQUALS( std::string("[test.cpp:5]: If the result is negative it will be wrong because an operand is unsigned.\n"), errout.str() ); + } +}; + +REGISTER_FIXTURE( TestDivision ) + +