walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #5381 (Some false positives that came up when using --enable=performance file.c)

This commit is contained in:
Daniel Marjamäki 2014-02-23 11:02:39 +01:00
parent 43d48574c5
commit 8dd7f02e45
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkother.cpp
View File

@ -669,7 +669,7 @@ void CheckOther::checkRedundantAssignment()
} else if (Token::Match(tok, "break|return|continue|throw|goto")) { } else if (Token::Match(tok, "break|return|continue|throw|goto")) {
varAssignments.clear(); varAssignments.clear();
memAssignments.clear(); memAssignments.clear();
} else if (tok->type() == Token::eVariable) { } else if (tok->type() == Token::eVariable && !Token::Match(tok,"%var% (")) {
// Set initialization flag // Set initialization flag
if (!Token::Match(tok, "%var% [")) if (!Token::Match(tok, "%var% ["))
initialized.insert(tok->varId()); initialized.insert(tok->varId());

11
test/testother.cpp
View File

@ -6374,6 +6374,17 @@ private:
"}"); "}");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
check("struct AB { int a; int b; };\n"
"\n"
"int f(DO_SOMETHING do_something) {\n"
" struct AB ab;\n"
" ab.a = 1;\n"
" do_something(&ab);\n"
" ab.a = 2;\n"
" return ab.a;\n"
"}");
ASSERT_EQUALS("", errout.str());
check("struct AB { int a; int b; };\n" check("struct AB { int a; int b; };\n"
"\n" "\n"
"int f(struct AB *ab) {\n" "int f(struct AB *ab) {\n"