walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #7232 (False positive unknownEvaluationOrder on id = Remap( id += 42 );)

This commit is contained in:
Daniel Marjamäki 2015-12-25 16:45:11 +01:00
parent 0bdd353062
commit 90a54b1fae
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/checkother.cpp
View File

@ -2495,6 +2495,7 @@ void CheckOther::checkEvaluationOrder()
if (!tok->astOperand1())
continue;
for (const Token *tok2 = tok; tok2 && tok2->astParent(); tok2 = tok2->astParent()) {
// If ast parent is a sequence point then break
const Token * const parent = tok2->astParent();
if (Token::Match(parent, "%oror%|&&|?|:|;"))
break;
@ -2505,6 +2506,8 @@ void CheckOther::checkEvaluationOrder()
if (!par || par->str() != "(")
break;
}
if (parent->str() == "(" && parent->astOperand2())
break;
// Is expression used?
bool foundError = false;

6
test/testother.cpp
View File

@ -6111,6 +6111,12 @@ private:
" return strtol(++exp, (char **)&exp, 10);\n"
"}");
ASSERT_EQUALS("[test.cpp:2]: (error) Expression '++exp,(char**)&exp' depends on order of evaluation of side effects\n", errout.str());
// sequence points
check("void f(int id) {\n"
" id = dostuff(id += 42);\n"
"}");
ASSERT_EQUALS("", errout.str());
}
};