From 93903d96c4d5f178f056d258e26072f1157d9f48 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Marjam=C3=A4ki?= <daniel.marjamaki@gmail.com>
Date: Fri, 13 Jul 2018 18:52:03 +0200
Subject: [PATCH] Refactoring, use Token::isUnaryOp and Token::isBinaryOp

---
 lib/astutils.cpp | 10 +++++-----
 lib/token.h      |  7 +++++--
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/lib/astutils.cpp b/lib/astutils.cpp
index 74f4717bb..546569d54 100644
--- a/lib/astutils.cpp
+++ b/lib/astutils.cpp
@@ -235,14 +235,14 @@ bool isSameExpression(bool cpp, bool macro, const Token *tok1, const Token *tok2
         return true;
 
     // in c++, a+b might be different to b+a, depending on the type of a and b
-    if (cpp && tok1->str() == "+" && tok1->astOperand2()) {
+    if (cpp && tok1->str() == "+" && tok1->isBinaryOp()) {
         const ValueType* vt1 = tok1->astOperand1()->valueType();
         const ValueType* vt2 = tok1->astOperand2()->valueType();
         if (!(vt1 && (vt1->type >= ValueType::VOID || vt1->pointer) && vt2 && (vt2->type >= ValueType::VOID || vt2->pointer)))
             return false;
     }
 
-    const bool commutative = tok1->astOperand1() && tok1->astOperand2() && Token::Match(tok1, "%or%|%oror%|+|*|&|&&|^|==|!=");
+    const bool commutative = tok1->isBinaryOp() && Token::Match(tok1, "%or%|%oror%|+|*|&|&&|^|==|!=");
     bool commutativeEquals = commutative &&
                              isSameExpression(cpp, macro, tok1->astOperand2(), tok2->astOperand1(), library, pure);
     commutativeEquals = commutativeEquals &&
@@ -398,9 +398,9 @@ bool isOppositeExpression(bool cpp, const Token * const tok1, const Token * cons
         return false;
     if (isOppositeCond(true, cpp, tok1, tok2, library, pure))
         return true;
-    if (tok1->str() == "-" && !tok1->astOperand2())
+    if (tok1->isUnaryOp("-"))
         return isSameExpression(cpp, true, tok1->astOperand1(), tok2, library, pure);
-    if (tok2->str() == "-" && !tok2->astOperand2())
+    if (tok2->isUnaryOp("-"))
         return isSameExpression(cpp, true, tok2->astOperand1(), tok1, library, pure);
     return false;
 }
@@ -733,7 +733,7 @@ bool isLikelyStreamRead(bool cpp, const Token *op)
     if (!cpp)
         return false;
 
-    if (!Token::Match(op, "&|>>") || !op->astOperand2())
+    if (!Token::Match(op, "&|>>") || !op->isBinaryOp())
         return false;
 
     if (!Token::Match(op->astOperand2(), "%name%|.|*|[") && op->str() != op->astOperand2()->str())
diff --git a/lib/token.h b/lib/token.h
index 381fa8c83..2aa038d51 100644
--- a/lib/token.h
+++ b/lib/token.h
@@ -309,8 +309,11 @@ public:
     bool isBoolean() const {
         return mTokType == eBoolean;
     }
-    bool isUnaryOp() const {
-        return astOperand1() != nullptr && astOperand2() == nullptr;
+    bool isBinaryOp() const {
+        return astOperand1() != nullptr && astOperand2() != nullptr;
+    }
+    bool isUnaryOp(const std::string &s) const {
+        return s == mStr && astOperand1() != nullptr && astOperand2() == nullptr;
     }
     bool isUnaryPreOp() const;