walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Remove useless forward declarations 

Instead move the 'static' keyword to the function implementation.
This commit is contained in:
Thomas Jarosch 2015-01-08 23:58:00 +01:00
parent 2375f1c46d
commit 965775423b
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/dmake.cpp
View File

@ -27,25 +27,20 @@
#include "../cli/filelister.h" #include "../cli/filelister.h"
static std::string builddir(std::string filename); static std::string builddir(std::string filename)
static std::string objfile(std::string cppfile);
static void getDeps(const std::string &filename, std::vector<std::string> &depfiles);
std::string builddir(std::string filename)
{ {
if (filename.compare(0,4,"lib/") == 0) if (filename.compare(0,4,"lib/") == 0)
filename = "$(SRCDIR)" + filename.substr(3); filename = "$(SRCDIR)" + filename.substr(3);
return filename; return filename;
} }
std::string objfile(std::string cppfile) static std::string objfile(std::string cppfile)
{ {
cppfile.erase(cppfile.rfind(".")); cppfile.erase(cppfile.rfind("."));
return builddir(cppfile + ".o"); return builddir(cppfile + ".o");
} }
void getDeps(const std::string &filename, std::vector<std::string> &depfiles) static void getDeps(const std::string &filename, std::vector<std::string> &depfiles)
{ {
// Is the dependency already included? // Is the dependency already included?
if (std::find(depfiles.begin(), depfiles.end(), filename) != depfiles.end()) if (std::find(depfiles.begin(), depfiles.end(), filename) != depfiles.end())