walkero/cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #5033 (segmentation fault (valid code) in CheckOther::checkZeroDivisionOrUselessCondition)

Browse Source
This commit is contained in:
Daniel Marjamäki 2013-09-21 17:44:25 +02:00
parent 4cc153a6f3
commit 965d8f0ecc
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkother.cpp
View File

@ -2192,6 +2192,8 @@ void CheckOther::checkZeroDivisionOrUselessCondition()
ftok = ftok ? ftok->previous() : NULL; ftok = ftok ? ftok->previous() : NULL;
} }
ftok = ftok ? ftok->previous() : NULL; ftok = ftok ? ftok->previous() : NULL;
if (!ftok)
continue;
if (!Token::Match(ftok, "%var% (") && ftok->function()) if (!Token::Match(ftok, "%var% (") && ftok->function())
continue; continue;

9
test/testother.cpp
View File

@ -508,6 +508,15 @@ private:
" while (y || x == 0) { x--; }\n" " while (y || x == 0) { x--; }\n"
"}"); "}");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
// ticket 5033 segmentation fault (valid code) in CheckOther::checkZeroDivisionOrUselessCondition
check("void f() {\n"
"double* p1= new double[1];\n"
"double* p2= new double[1];\n"
"double* p3= new double[1];\n"
"double* pp[3] = {p1,p2,p3};\n"
"}");
ASSERT_EQUALS("", errout.str());
} }
void nanInArithmeticExpression() { void nanInArithmeticExpression() {