walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

CheckClass: Disable noDestructor for now, we need to handle new better

This commit is contained in:
Daniel Marjamäki 2018-05-01 09:26:03 +02:00
parent 42100fdf11
commit 9710e819be
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/checkclass.cpp
View File

@ -345,8 +345,9 @@ void CheckClass::copyconstructors()
} }
if (!hasOperatorEq) if (!hasOperatorEq)
noOperatorEqError(scope); noOperatorEqError(scope);
if (!hasDestructor) if (!hasDestructor) {
noDestructorError(scope); // TODO: how are pointers allocated? noDestructorError(scope);
}
} }
std::set<const Token*> copiedVars; std::set<const Token*> copiedVars;

2
test/testclass.cpp
View File

@ -824,7 +824,7 @@ private:
" F(const F &f);\n" " F(const F &f);\n"
" F&operator=(const F&);" " F&operator=(const F&);"
"};"); "};");
ASSERT_EQUALS("[test.cpp:1]: (style) struct 'F' does not have a destructor which is recommended since the class contains a pointer to allocated memory.\n", errout.str()); // TODO ASSERT_EQUALS("[test.cpp:1]: (style) struct 'F' does not have a destructor which is recommended since the class contains a pointer to allocated memory.\n", errout.str());
} }
// Check the operator Equal // Check the operator Equal