walkero/cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

added log10() check, for checking about parameters passed to mathfunctions that do not make sense

Browse Source
This commit is contained in:
Martin Ettl 2010-04-02 19:17:41 +02:00
parent 4225544c82
commit 9788333ee9
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/checkother.cpp
View File

@ -2440,7 +2440,7 @@ void CheckOther::checkMathFunctions()
for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next()) for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next())
{ {
// case log(-2) // case log(-2)
if (Token::Match(tok, "log ( %num% )") && if (Token::Match(tok, "log|log10 ( %num% )") &&
MathLib::isNegative(tok->tokAt(2)->str()) && MathLib::isNegative(tok->tokAt(2)->str()) &&
MathLib::isInt(tok->tokAt(2)->str()) && MathLib::isInt(tok->tokAt(2)->str()) &&
MathLib::toLongNumber(tok->tokAt(2)->str()) <= 0) MathLib::toLongNumber(tok->tokAt(2)->str()) <= 0)
@ -2448,7 +2448,7 @@ void CheckOther::checkMathFunctions()
mathfunctionCallError(tok); mathfunctionCallError(tok);
} }
// case log(-2.0) // case log(-2.0)
else if (Token::Match(tok, "log ( %num% )") && else if (Token::Match(tok, "log|log10 ( %num% )") &&
MathLib::isNegative(tok->tokAt(2)->str()) && MathLib::isNegative(tok->tokAt(2)->str()) &&
MathLib::isFloat(tok->tokAt(2)->str()) && MathLib::isFloat(tok->tokAt(2)->str()) &&
MathLib::toDoubleNumber(tok->tokAt(2)->str()) <= 0.) MathLib::toDoubleNumber(tok->tokAt(2)->str()) <= 0.)
@ -2457,7 +2457,7 @@ void CheckOther::checkMathFunctions()
} }
// case log(0.0) // case log(0.0)
else if (Token::Match(tok, "log ( %num% )") && else if (Token::Match(tok, "log|log10 ( %num% )") &&
!MathLib::isNegative(tok->tokAt(2)->str()) && !MathLib::isNegative(tok->tokAt(2)->str()) &&
MathLib::isFloat(tok->tokAt(2)->str()) && MathLib::isFloat(tok->tokAt(2)->str()) &&
MathLib::toDoubleNumber(tok->tokAt(2)->str()) <= 0.) MathLib::toDoubleNumber(tok->tokAt(2)->str()) <= 0.)
@ -2466,7 +2466,7 @@ void CheckOther::checkMathFunctions()
} }
// case log(0) // case log(0)
else if (Token::Match(tok, "log ( %num% )") && else if (Token::Match(tok, "log|log10 ( %num% )") &&
!MathLib::isNegative(tok->tokAt(2)->str()) && !MathLib::isNegative(tok->tokAt(2)->str()) &&
MathLib::isInt(tok->tokAt(2)->str()) && MathLib::isInt(tok->tokAt(2)->str()) &&
MathLib::toLongNumber(tok->tokAt(2)->str()) <= 0) MathLib::toLongNumber(tok->tokAt(2)->str()) <= 0)