walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

STL if find: check given severity

This commit is contained in:
Daniel Marjamäki 2010-02-28 06:56:47 +01:00
parent 88840e6a08
commit 980a810995
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/checkstl.cpp
View File

@ -535,6 +535,8 @@ void CheckStl::findError(const Token *tok)
void CheckStl::if_find() void CheckStl::if_find()
{ {
if (!_settings->_checkCodingStyle)
return;
for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next()) for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next())
{ {
if (Token::Match(tok, "if ( !| %var% . find ( %any% ) )")) if (Token::Match(tok, "if ( !| %var% . find ( %any% ) )"))
@ -549,7 +551,7 @@ void CheckStl::if_find()
{ {
// Locate variable declaration.. // Locate variable declaration..
const Token * const decl = Token::findmatch(_tokenizer->tokens(), "%varid%", varid); const Token * const decl = Token::findmatch(_tokenizer->tokens(), "%varid%", varid);
if (Token::Match(decl->tokAt(-4), ",|;|( std :: string")) if (_settings->_showAll && Token::Match(decl->tokAt(-4), ",|;|( std :: string"))
if_findError(tok, true); if_findError(tok, true);
else if (Token::Match(decl->tokAt(-7), ",|;|( std :: %type% < %type% >")) else if (Token::Match(decl->tokAt(-7), ",|;|( std :: %type% < %type% >"))
if_findError(tok, false); if_findError(tok, false);