walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #1304 (False positive: The function 'x' can be const when modifing a member)

This commit is contained in:
Daniel Marjamäki 2010-01-23 20:59:20 +01:00
parent 5b76be4935
commit 9a6b450501
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/checkclass.cpp
View File

@ -1455,8 +1455,18 @@ void CheckClass::checkConst()
break; break;
--indentlevel; --indentlevel;
} }
// assignment.. = += |= ..
else if (tok3->str() == "=" || else if (tok3->str() == "=" ||
Token::Match(tok, "%var% (")) (tok3->str().find("=") == 1 &&
tok3->str().find_first_of("<>") == std::string::npos))
{
isconst = false;
break;
}
// function call..
else if (Token::Match(tok, "%var% ("))
{ {
isconst = false; isconst = false;
break; break;

7
test/testclass.cpp
View File

@ -1539,6 +1539,13 @@ private:
"};\n"); "};\n");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
// assignment through |=..
checkConst("class Fred {\n"
" int a;\n"
" int setA() { a |= true; }\n"
"};\n");
ASSERT_EQUALS("", errout.str());
} }
}; };