From 9c9e920829b0dd34def7786eb17de867f2e1b7f8 Mon Sep 17 00:00:00 2001
From: Reijo Tomperi <aggro80@users.sourceforge.net>
Date: Mon, 13 Apr 2009 12:02:21 +0300
Subject: [PATCH] Fix ticket #252 (Fix --style warnings in cppcheck)
 http://apps.sourceforge.net/trac/cppcheck/ticket/252

---
 cppcheck.cbp          | 5 +++++
 gui/threadhandler.cpp | 1 -
 src/check.h           | 4 ++--
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/cppcheck.cbp b/cppcheck.cbp
index 50e0522be..bbf659254 100644
--- a/cppcheck.cbp
+++ b/cppcheck.cbp
@@ -34,6 +34,7 @@
 		<Unit filename="gui/checkdialog.h" />
 		<Unit filename="gui/checkthread.cpp" />
 		<Unit filename="gui/checkthread.h" />
+		<Unit filename="gui/common.h" />
 		<Unit filename="gui/main.cpp" />
 		<Unit filename="gui/mainwindow.cpp" />
 		<Unit filename="gui/mainwindow.h" />
@@ -43,6 +44,10 @@
 		<Unit filename="gui/resultsview.h" />
 		<Unit filename="gui/settingsdialog.cpp" />
 		<Unit filename="gui/settingsdialog.h" />
+		<Unit filename="gui/threadhandler.cpp" />
+		<Unit filename="gui/threadhandler.h" />
+		<Unit filename="gui/threadresult.cpp" />
+		<Unit filename="gui/threadresult.h" />
 		<Unit filename="src/check.h" />
 		<Unit filename="src/checkautovariables.cpp" />
 		<Unit filename="src/checkautovariables.h" />
diff --git a/gui/threadhandler.cpp b/gui/threadhandler.cpp
index e7e84de54..c641f3eab 100644
--- a/gui/threadhandler.cpp
+++ b/gui/threadhandler.cpp
@@ -41,7 +41,6 @@ void ThreadHandler::SetFiles(const QStringList &files)
 {
     mResults.SetFiles(files);
     mLastFiles = files;
-    QString file;
 }
 
 void ThreadHandler::Check(Settings settings, bool recheck)
diff --git a/src/check.h b/src/check.h
index 12a32b860..d88047c01 100644
--- a/src/check.h
+++ b/src/check.h
@@ -69,7 +69,7 @@ protected:
     ErrorLogger * const _errorLogger;
 
     /** report an error */
-    void reportError(const Token *tok, const std::string severity, const std::string id, const std::string msg)
+    void reportError(const Token *tok, const std::string &severity, const std::string &id, const std::string &msg)
     {
         std::list<const Token *> callstack;
         callstack.push_back(tok);
@@ -77,7 +77,7 @@ protected:
     }
 
     /** report an error */
-    void reportError(const std::list<const Token *> callstack, const std::string severity, const std::string id, const std::string msg)
+    void reportError(const std::list<const Token *> &callstack, const std::string &severity, const std::string &id, const std::string &msg)
     {
         std::list<ErrorLogger::ErrorMessage::FileLocation> locationList;
         for (std::list<const Token *>::const_iterator it = callstack.begin(); it != callstack.end(); ++it)