walkero/cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Refactoring; Use stl algorithm instead of for loop

Browse Source
This commit is contained in:
Daniel Marjamäki 2019-04-28 10:30:20 +02:00
parent f503386666
commit 9d72e24edb
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/checkbufferoverrun.cpp
View File

@ -590,13 +590,9 @@ void CheckBufferOverrun::bufferOverflow()
const ValueFlow::Value bufferSize = getBufferSize(argtok); const ValueFlow::Value bufferSize = getBufferSize(argtok);
if (bufferSize.intvalue <= 1) if (bufferSize.intvalue <= 1)
continue; continue;
bool error = true; bool error = std::none_of(minsizes->begin(), minsizes->end(), [=](const Library::ArgumentChecks::MinSize &minsize) {
for (const Library::ArgumentChecks::MinSize &minsize : *minsizes) { return checkBufferSize(tok, minsize, args, bufferSize.intvalue, mSettings);
if (checkBufferSize(tok, minsize, args, bufferSize.intvalue, mSettings)) { });
error = false;
break;
}
}
if (error) if (error)
bufferOverflowError(args[argnr], &bufferSize); bufferOverflowError(args[argnr], &bufferSize);
} }