walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

CheckNullPointer::isPointerDeref: better checking if pointer is not dereferenced

This commit is contained in:
Daniel Marjamäki 2011-12-15 17:01:39 +01:00
parent 3a432fa959
commit 9e54714894
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/checknullpointer.cpp
View File

@ -252,7 +252,7 @@ bool CheckNullPointer::isPointerDeRef(const Token *tok, bool &unknown)
// This is most useful in inconclusive checking // This is most useful in inconclusive checking
if (inconclusive) { if (inconclusive) {
// Not a dereference.. // Not a dereference..
if (Token::Match(tok->previous(), "[;{}] %var% =")) if (Token::Match(tok->previous(), "[;{}(] %var% ="))
return false; return false;
// OK to delete a null // OK to delete a null
@ -265,7 +265,15 @@ bool CheckNullPointer::isPointerDeRef(const Token *tok, bool &unknown)
return false; return false;
// OK to pass pointer to function // OK to pass pointer to function
if (Token::Match(tok->previous(), ", %var% [,)]")) if (Token::Match(tok->previous(), "[(,] %var% [,)]"))
return false;
// Compare pointer
if (Token::Match(tok->previous(), "(|&&|%oror%|==|!= %var% &&|%oror%|)"))
return false;
// Taking address
if (Token::Match(tok->previous(), "return|= %var% ;"))
return false; return false;
// unknown if it's a dereference // unknown if it's a dereference