walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Ticket #7820: Properly report leaks with conditional deallocations followed by a return.

This commit is contained in:
Simon Martin 2017-01-14 12:16:47 +01:00
parent 982991fabe
commit 9e76b21d7f
2 changed files with 36 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/checkmemoryleak.cpp
View File

@ -1968,8 +1968,8 @@ const Token *CheckMemoryLeakInFunction::findleak(const Token *tokens)
return result->tokAt(4); return result->tokAt(4);
} }
if (((result = Token::findsimplematch(tokens, "; alloc ; if dealloc ; }")) != nullptr) && if (((result = Token::findsimplematch(tokens, "; alloc ; if dealloc ; }")) != nullptr) ||
!result->tokAt(7)) { ((result = Token::findsimplematch(tokens, "; alloc ; if dealloc ; return ;")) != nullptr)) {
return result->tokAt(6); return result->tokAt(6);
} }

34
test/testmemleak.cpp
View File

@ -314,6 +314,7 @@ private:
TEST_CASE(autoptr1); TEST_CASE(autoptr1);
TEST_CASE(if_with_and); TEST_CASE(if_with_and);
TEST_CASE(assign_pclose); TEST_CASE(assign_pclose);
TEST_CASE(conditional_dealloc_return); // #7820
// Using the function "exit" // Using the function "exit"
TEST_CASE(exit2); TEST_CASE(exit2);
@ -3376,6 +3377,39 @@ private:
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void conditional_dealloc_return() { // #7820
check("void f() {\n"
" FILE *pPipe = popen(\"foo\", \"r\");\n"
" if (feof(pPipe))\n"
" pclose(pPipe);\n"
" return;\n"
"}", /*c=*/true, /*posix=*/true);
ASSERT_EQUALS("[test.c:5]: (error) Resource leak: pPipe\n", errout.str());
check("extern int bar();\n"
"void f() {\n"
" char *c = (char*) malloc(10);\n"
" if (bar())\n"
" free(c);\n"
" return;\n"
"}", /*c=*/true);
ASSERT_EQUALS("[test.c:6]: (error) Memory leak: c\n", errout.str());
check("extern int bar();\n"
"extern int baz();\n"
"extern void bos(char*);\n"
"void f() {\n"
" char *c;\n"
" if(bar()) {\n"
" bos(c);\n"
" c = (char*) malloc(10);\n"
" if (baz())\n"
" free(c);\n"
" };\n"
"}", /*c=*/true);
ASSERT_EQUALS("[test.c:11]: (error) Memory leak: c\n", errout.str());
}
void exit2() { void exit2() {
check("void f()\n" check("void f()\n"
"{\n" "{\n"