walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #2117 (false positive: buffer access out of bounds)

This commit is contained in:
Daniel Marjamäki 2010-10-22 20:15:51 +02:00
parent 2346ab8839
commit 9fdc03fc1d
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/checkbufferoverrun.cpp
View File

@ -1174,7 +1174,9 @@ void CheckBufferOverrun::checkGlobalAndLocalVariable()
varid = tok->tokAt(1)->varId(); varid = tok->tokAt(1)->varId();
nextTok = 8; nextTok = 8;
} }
else if (indentlevel > 0 && Token::Match(tok, "[;{}] %var% = %str% ;")) else if (indentlevel > 0 &&
Token::Match(tok, "[;{}] %var% = %str% ;") &&
NULL != Token::findmatch(_tokenizer->tokens(), "[;{}] const| %type% * %varid% ;", tok->next()->varId()))
{ {
size = 1 + int(tok->tokAt(3)->strValue().size()); size = 1 + int(tok->tokAt(3)->strValue().size());
type = "char"; type = "char";

11
test/testbufferoverrun.cpp
View File

@ -137,6 +137,7 @@ private:
TEST_CASE(sprintf7); TEST_CASE(sprintf7);
TEST_CASE(sprintf8); TEST_CASE(sprintf8);
TEST_CASE(sprintf9); TEST_CASE(sprintf9);
TEST_CASE(sprintf10);
TEST_CASE(snprintf1); TEST_CASE(snprintf1);
TEST_CASE(snprintf2); TEST_CASE(snprintf2);
@ -1835,6 +1836,16 @@ private:
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void sprintf10()
{
check("void f()\n"
"{\n"
" TString str = \"\";\n"
" sprintf(str, \"1\");\n"
"}\n");
ASSERT_EQUALS("", errout.str());
}
void snprintf1() void snprintf1()
{ {
check("void f()\n" check("void f()\n"