walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

donate-cpu-server.py: Optimize checkLibrary* report generation 

Use lists that are joined in the end instead of slower string concatenations with `+`.
Tested locally
This commit is contained in:
versat 2019-02-12 08:53:03 +01:00
parent 6459de0aad
commit a1d0509d61
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tools/donate-cpu-server.py
View File

@ -521,15 +521,14 @@ def check_library_report(result_path, message_id):
function_name = line[(line.find(': Function ') + len(': Function ')):line.rfind('should have') - 1] function_name = line[(line.find(': Function ') + len(': Function ')):line.rfind('should have') - 1]
function_counts[function_name] = function_counts.setdefault(function_name, 0) + 1 function_counts[function_name] = function_counts.setdefault(function_name, 0) + 1
functions_shown = 0 function_details_list = list()
for function_name, count in sorted(function_counts.iteritems(), key=lambda (k, v): (v, k), reverse=True): for function_name, count in sorted(function_counts.iteritems(), key=lambda (k, v): (v, k), reverse=True):
if functions_shown >= functions_shown_max: if len(function_details_list) >= functions_shown_max:
break break
html += str(count).rjust(column_widths[0]) + ' ' + \ function_details_list.append(str(count).rjust(column_widths[0]) + ' ' +
'<a href="check_library-' + urllib.quote_plus(function_name) + '">' + function_name + '</a>\n' '<a href="check_library-' + urllib.quote_plus(function_name) + '">' + function_name + '</a>\n')
functions_shown += 1
html += '\n' html += ''.join(function_details_list)
html += '</pre>\n' html += '</pre>\n'
html += '</body></html>\n' html += '</body></html>\n'
@ -539,8 +538,8 @@ def check_library_report(result_path, message_id):
# Lists all checkLibrary* messages regarding the given function name # Lists all checkLibrary* messages regarding the given function name
def check_library_function_name(result_path, function_name): def check_library_function_name(result_path, function_name):
print('check_library_function_name') print('check_library_function_name')
text = ''
function_name = urllib.unquote_plus(function_name) function_name = urllib.unquote_plus(function_name)
output_lines_list = list()
for filename in glob.glob(result_path + '/*'): for filename in glob.glob(result_path + '/*'):
if not os.path.isfile(filename): if not os.path.isfile(filename):
continue continue
@ -559,14 +558,14 @@ def check_library_function_name(result_path, function_name):
if '[checkLibrary' in line: if '[checkLibrary' in line:
if (' ' + function_name) in line: if (' ' + function_name) in line:
if url: if url:
text += url output_lines_list.append(url)
url = None url = None
if cppcheck_options: if cppcheck_options:
text += cppcheck_options output_lines_list.append(cppcheck_options)
cppcheck_options = None cppcheck_options = None
text += line output_lines_list.append(line)
return text return ''.join(output_lines_list)
def sendAll(connection, data): def sendAll(connection, data):