walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Running astyle. There is no functional change intended.

This commit is contained in:
orbitcowboy 2018-09-21 08:53:09 +02:00
parent 2675793e31
commit a26ac4d266
2 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkstl.h
View File

@ -184,7 +184,7 @@ public:
/** @brief Look for loops that can replaced with std algorithms */ /** @brief Look for loops that can replaced with std algorithms */
void useStlAlgorithm(); void useStlAlgorithm();
private: private:
void missingComparisonError(const Token* incrementToken1, const Token* incrementToken2); void missingComparisonError(const Token* incrementToken1, const Token* incrementToken2);
void string_c_strThrowError(const Token* tok); void string_c_strThrowError(const Token* tok);
void string_c_strError(const Token* tok); void string_c_strError(const Token* tok);

18
test/teststl.cpp
View File

@ -3164,8 +3164,7 @@ private:
ASSERT_EQUALS("[test.cpp:18]: (error, inconclusive) Invalid iterator 'it' used.\n", errout.str()); ASSERT_EQUALS("[test.cpp:18]: (error, inconclusive) Invalid iterator 'it' used.\n", errout.str());
} }
void loopAlgoElementAssign() void loopAlgoElementAssign() {
{
check("void foo() {\n" check("void foo() {\n"
" for(int& x:v)\n" " for(int& x:v)\n"
" x = 1;\n" " x = 1;\n"
@ -3237,8 +3236,7 @@ private:
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void loopAlgoAccumulateAssign() void loopAlgoAccumulateAssign() {
{
check("void foo() {\n" check("void foo() {\n"
" int n = 0;\n" " int n = 0;\n"
" for(int x:v)\n" " for(int x:v)\n"
@ -3316,8 +3314,7 @@ private:
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void loopAlgoContainerInsert() void loopAlgoContainerInsert() {
{
check("void foo() {\n" check("void foo() {\n"
" std::vector<int> c;\n" " std::vector<int> c;\n"
" for(int x:v)\n" " for(int x:v)\n"
@ -3383,8 +3380,7 @@ private:
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void loopAlgoIncrement() void loopAlgoIncrement() {
{
check("void foo() {\n" check("void foo() {\n"
" int n = 0;\n" " int n = 0;\n"
" for(int x:v)\n" " for(int x:v)\n"
@ -3416,8 +3412,7 @@ private:
ASSERT_EQUALS("[test.cpp:3]: (style) Consider using std::transform algorithm instead of a raw loop.\n", errout.str()); ASSERT_EQUALS("[test.cpp:3]: (style) Consider using std::transform algorithm instead of a raw loop.\n", errout.str());
} }
void loopAlgoConditional() void loopAlgoConditional() {
{
check("bool pred(int x);\n" check("bool pred(int x);\n"
"void foo() {\n" "void foo() {\n"
" for(int& x:v) {\n" " for(int& x:v) {\n"
@ -3629,8 +3624,7 @@ private:
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void loopAlgoMinMax() void loopAlgoMinMax() {
{
check("void foo() {\n" check("void foo() {\n"
" int n = 0;\n" " int n = 0;\n"
" for(int x:v)\n" " for(int x:v)\n"