walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

misra: Don't consider variadic arguments as the violation of rule 2.7 (#3315) 

The MISRA 2012 standard does not say anything about variadic functions
in the definition of rule 2.7. Therefore, these cases should be
considered as false positives.
This commit is contained in:
Georgiy Komarov 2021-06-29 09:46:35 +03:00 committed by GitHub
parent 2bc87d13e1
commit a2cb9f17c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
addons/misra.py
View File

@ -1123,7 +1123,10 @@ class MisraChecker:
# Setup list of function parameters # Setup list of function parameters
func_param_list = list() func_param_list = list()
for arg in func.argument: for arg in func.argument:
func_param_list.append(func.argument[arg]) func_arg = func.argument[arg]
if func_arg.typeStartToken and func_arg.typeStartToken.str == '...':
continue
func_param_list.append(func_arg)
# Search for scope of current function # Search for scope of current function
for scope in data.scopes: for scope in data.scopes:
if (scope.type == "Function") and (scope.function == func): if (scope.type == "Function") and (scope.function == func):

3
addons/test/misra/misra-test.c
View File

@ -65,6 +65,9 @@ void misra_2_7_used_params (int *param1, int param2, int param3)
*param1 = param2; *param1 = param2;
} }
void misra_2_7_vararg(int a, ...) { (void)a; }
void misra_2_7_unnamed_arg(int) { } // 2.7 8.2
void misra_3_2(int enable) void misra_3_2(int enable)
{ {
// This won't generate a violation because of subsequent blank line \ // This won't generate a violation because of subsequent blank line \