Fixed #1933 (Add checks for obsolete functions)
This commit is contained in:
Sbastien Debrard
Daniel Marjamäki
parent
00dc3adc18
commit
a55a06cea5
8
Makefile
8
Makefile
|
|
@ -16,6 +16,7 @@ LIBOBJ = lib/checkautovariables.o \
|
||||||
lib/checkdangerousfunctions.o \
|
lib/checkdangerousfunctions.o \
|
||||||
lib/checkexceptionsafety.o \
|
lib/checkexceptionsafety.o \
|
||||||
lib/checkmemoryleak.o \
|
lib/checkmemoryleak.o \
|
||||||
|
lib/checkobsoletefunctions.o \
|
||||||
lib/checkother.o \
|
lib/checkother.o \
|
||||||
lib/checkstl.o \
|
lib/checkstl.o \
|
||||||
lib/checkunusedfunctions.o \
|
lib/checkunusedfunctions.o \
|
||||||
|
|
@ -49,6 +50,7 @@ TESTOBJ = test/testautovariables.o \
|
||||||
test/testincompletestatement.o \
|
test/testincompletestatement.o \
|
||||||
test/testmathlib.o \
|
test/testmathlib.o \
|
||||||
test/testmemleak.o \
|
test/testmemleak.o \
|
||||||
|
test/testobsoletefunctions.o \
|
||||||
test/testother.o \
|
test/testother.o \
|
||||||
test/testpreprocessor.o \
|
test/testpreprocessor.o \
|
||||||
test/testredundantif.o \
|
test/testredundantif.o \
|
||||||
|
|
@ -116,6 +118,9 @@ lib/checkexceptionsafety.o: lib/checkexceptionsafety.cpp lib/checkexceptionsafet
|
||||||
lib/checkmemoryleak.o: lib/checkmemoryleak.cpp lib/checkmemoryleak.h lib/check.h lib/token.h lib/tokenize.h lib/classinfo.h lib/settings.h lib/errorlogger.h lib/mathlib.h lib/executionpath.h
|
lib/checkmemoryleak.o: lib/checkmemoryleak.cpp lib/checkmemoryleak.h lib/check.h lib/token.h lib/tokenize.h lib/classinfo.h lib/settings.h lib/errorlogger.h lib/mathlib.h lib/executionpath.h
|
||||||
$(CXX) $(CXXFLAGS) -Ilib -c -o lib/checkmemoryleak.o lib/checkmemoryleak.cpp
|
$(CXX) $(CXXFLAGS) -Ilib -c -o lib/checkmemoryleak.o lib/checkmemoryleak.cpp
|
||||||
|
|
||||||
|
lib/checkobsoletefunctions.o: lib/checkobsoletefunctions.cpp lib/checkobsoletefunctions.h lib/check.h lib/token.h lib/tokenize.h lib/classinfo.h lib/settings.h lib/errorlogger.h
|
||||||
|
$(CXX) $(CXXFLAGS) -Ilib -c -o lib/checkobsoletefunctions.o lib/checkobsoletefunctions.cpp
|
||||||
|
|
||||||
lib/checkother.o: lib/checkother.cpp lib/checkother.h lib/check.h lib/token.h lib/tokenize.h lib/classinfo.h lib/settings.h lib/errorlogger.h lib/mathlib.h lib/executionpath.h
|
lib/checkother.o: lib/checkother.cpp lib/checkother.h lib/check.h lib/token.h lib/tokenize.h lib/classinfo.h lib/settings.h lib/errorlogger.h lib/mathlib.h lib/executionpath.h
|
||||||
$(CXX) $(CXXFLAGS) -Ilib -c -o lib/checkother.o lib/checkother.cpp
|
$(CXX) $(CXXFLAGS) -Ilib -c -o lib/checkother.o lib/checkother.cpp
|
||||||
|
|
||||||
|
|
@ -209,6 +214,9 @@ test/testmathlib.o: test/testmathlib.cpp lib/mathlib.h test/testsuite.h lib/erro
|
||||||
test/testmemleak.o: test/testmemleak.cpp lib/tokenize.h lib/classinfo.h lib/token.h lib/checkmemoryleak.h lib/check.h lib/settings.h lib/errorlogger.h test/testsuite.h
|
test/testmemleak.o: test/testmemleak.cpp lib/tokenize.h lib/classinfo.h lib/token.h lib/checkmemoryleak.h lib/check.h lib/settings.h lib/errorlogger.h test/testsuite.h
|
||||||
$(CXX) $(CXXFLAGS) -Ilib -Icli -c -o test/testmemleak.o test/testmemleak.cpp
|
$(CXX) $(CXXFLAGS) -Ilib -Icli -c -o test/testmemleak.o test/testmemleak.cpp
|
||||||
|
|
||||||
|
test/testobsoletefunctions.o: test/testobsoletefunctions.cpp lib/tokenize.h lib/classinfo.h lib/token.h lib/checkobsoletefunctions.h lib/check.h lib/settings.h lib/errorlogger.h test/testsuite.h
|
||||||
|
$(CXX) $(CXXFLAGS) -Ilib -Icli -c -o test/testobsoletefunctions.o test/testobsoletefunctions.cpp
|
||||||
|
|
||||||
test/testother.o: test/testother.cpp lib/tokenize.h lib/classinfo.h lib/token.h lib/checkother.h lib/check.h lib/settings.h lib/errorlogger.h test/testsuite.h
|
test/testother.o: test/testother.cpp lib/tokenize.h lib/classinfo.h lib/token.h lib/checkother.h lib/check.h lib/settings.h lib/errorlogger.h test/testsuite.h
|
||||||
$(CXX) $(CXXFLAGS) -Ilib -Icli -c -o test/testother.o test/testother.cpp
|
$(CXX) $(CXXFLAGS) -Ilib -Icli -c -o test/testother.o test/testother.cpp
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -0,0 +1,253 @@
|
||||||
|
/*
|
||||||
|
* Cppcheck - A tool for static C/C++ code analysis
|
||||||
|
* Copyright (C) 2007-2010 Daniel Marjamäki and Cppcheck team.
|
||||||
|
*
|
||||||
|
* This program is free software: you can redistribute it and/or modify
|
||||||
|
* it under the terms of the GNU General Public License as published by
|
||||||
|
* the Free Software Foundation, either version 3 of the License, or
|
||||||
|
* (at your option) any later version.
|
||||||
|
*
|
||||||
|
* This program is distributed in the hope that it will be useful,
|
||||||
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
* GNU General Public License for more details.
|
||||||
|
*
|
||||||
|
* You should have received a copy of the GNU General Public License
|
||||||
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||||
|
*/
|
||||||
|
|
||||||
|
//---------------------------------------------------------------------------
|
||||||
|
// Obsolete functions
|
||||||
|
//---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
#include "checkobsoletefunctions.h"
|
||||||
|
|
||||||
|
//---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
// Register this check class (by creating a static instance of it)
|
||||||
|
namespace
|
||||||
|
{
|
||||||
|
CheckObsoleteFunctions instance;
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctions()
|
||||||
|
{
|
||||||
|
if (!_settings->_checkCodingStyle)
|
||||||
|
return;
|
||||||
|
|
||||||
|
for (const Token *tok = _tokenizer->tokens(); tok; tok = tok->next())
|
||||||
|
{
|
||||||
|
if (tok->strAt(1) == "bsd_signal" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionbsd_signal(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "gethostbyaddr" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctiongethostbyaddr(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "gethostbyname" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctiongethostbyname(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "usleep" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionusleep(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "bcmp" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionbcmp(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "bcopy" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionbcopy(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "bzero" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionbzero(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "ecvt" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionecvt(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "fcvt" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionfcvt(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "gcvt" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctiongcvt(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "ftime" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionftime(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "getcontext" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctiongetcontext(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "makecontext" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionmakecontext(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "swapcontext" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionswapcontext(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "getwd" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctiongetwd(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "index" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionindex(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "pthread_attr_getstackaddr" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionpthread_attr_getstackaddr(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "pthread_attr_setstackaddr" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionpthread_attr_setstackaddr(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "rindex" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionrindex(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "scalb" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionscalb(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "ualarm" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionualarm(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "vfork" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionvfork(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
else if (tok->strAt(1) == "wcswcs" && tok->strAt(2) == "(" && tok->tokAt(1)->varId() == 0 && !tok->tokAt(0)->isName() && tok->strAt(0) != "." && tok->strAt(0) != "::")
|
||||||
|
{
|
||||||
|
obsoleteFunctionwcswcs(tok->tokAt(1));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
//---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionbsd_signal(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionbsd_signal", "Found obsolete function 'bsd_signal'. It is recommended that new applications use the 'sigaction' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctiongethostbyaddr(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctiongethostbyaddr", "Found obsolete function 'gethostbyaddr'. It is recommended that new applications use the 'getaddrinfo' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctiongethostbyname(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctiongethostbyname", "Found obsolete function 'gethostbyname'. It is recommended that new applications use the 'getnameinfo' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionusleep(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionusleep", "Found obsolete function 'usleep'. It is recommended that new applications use the 'nanosleep' or 'setitimer' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionbcmp(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionbcmp", "Found obsolete function 'bcmp'. It is recommended that new applications use the 'memcmp' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionbcopy(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionbcopy", "Found obsolete function 'bcopy'. It is recommended that new applications use the 'memmove' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionbzero(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionbzero", "Found obsolete function 'bzero'. It is recommended that new applications use the 'memset' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionecvt(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionecvt", "Found obsolete function 'ecvt'. It is recommended that new applications use the 'sprintf' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionfcvt(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionfcvt", "Found obsolete function 'fcvt'. It is recommended that new applications use the 'sprintf' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctiongcvt(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctiongcvt", "Found obsolete function 'gcvt'. It is recommended that new applications use the 'sprintf' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionftime(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionftime", "Found obsolete function 'ftime'. It is recommended that new applications use the 'ftime' function. Realtime applications should use ''clock_gettime'' to determine the current time");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctiongetcontext(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctiongetcontext", "Found obsolete function 'getcontext'. Due to portability issues with this function, applications are recommended to be rewritten to use POSIX threads");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionmakecontext(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionmakecontext", "Found obsolete function 'makecontext'. Due to portability issues with this function, applications are recommended to be rewritten to use POSIX threads");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionswapcontext(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionswapcontext", "Found obsolete function 'swapcontext'. Due to portability issues with this function, applications are recommended to be rewritten to use POSIX threads");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctiongetwd(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctiongetwd", "Found obsolete function 'getwd'. It is recommended that new applications use the 'getcwd' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionindex(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionindex", "Found obsolete function 'index'. It is recommended to use the function 'strchr' instead");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionpthread_attr_getstackaddr(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionpthread_attr_getstackaddr", "Found obsolete function 'pthread_attr_getstackaddr'.It is recommended that new applications use the 'pthread_attr_getstack' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionpthread_attr_setstackaddr(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionpthread_attr_setstackaddr", "Found obsolete function 'pthread_attr_setstackaddr'.It is recommended that new applications use the 'pthread_attr_setstack' function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionrindex(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionrindex", "Found obsolete function 'rindex'. It is recommended to use the function 'strrchr' instead");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionscalb(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionscalb", "Found obsolete function 'scalb'.It is recommended to use either 'scalbln', 'scalblnf()' or 'scalblnl' instead of this function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionualarm(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionualarm", "Found obsolete function 'ualarm'.It is recommended to use either 'timer_create', 'timer_delete', 'timer_getoverrun', 'timer_gettime', or 'timer_settime' instead of this function");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionvfork(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionvfork", "Found obsolete function 'vfork'. It is recommended to use the function 'fork' instead");
|
||||||
|
}
|
||||||
|
|
||||||
|
void CheckObsoleteFunctions::obsoleteFunctionwcswcs(const Token *tok)
|
||||||
|
{
|
||||||
|
reportError(tok, Severity::style, "obsoleteFunctionwcswcs", "Found obsolete function 'wcswcs'. It is recommended to use the function 'wcsstr' instead");
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
@ -0,0 +1,188 @@
|
||||||
|
/*
|
||||||
|
* Cppcheck - A tool for static C/C++ code analysis
|
||||||
|
* Copyright (C) 2007-2010 Daniel Marjamäki and Cppcheck team.
|
||||||
|
*
|
||||||
|
* This program is free software: you can redistribute it and/or modify
|
||||||
|
* it under the terms of the GNU General Public License as published by
|
||||||
|
* the Free Software Foundation, either version 3 of the License, or
|
||||||
|
* (at your option) any later version.
|
||||||
|
*
|
||||||
|
* This program is distributed in the hope that it will be useful,
|
||||||
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
* GNU General Public License for more details.
|
||||||
|
*
|
||||||
|
* You should have received a copy of the GNU General Public License
|
||||||
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||||
|
*/
|
||||||
|
|
||||||
|
|
||||||
|
//---------------------------------------------------------------------------
|
||||||
|
#ifndef CheckObsoleteFunctionsH
|
||||||
|
#define CheckObsoleteFunctionsH
|
||||||
|
//---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
#include "check.h"
|
||||||
|
|
||||||
|
/// @addtogroup Checks
|
||||||
|
/// @{
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @brief Using obsolete functions that are always insecure to use.
|
||||||
|
*/
|
||||||
|
|
||||||
|
class CheckObsoleteFunctions : public Check
|
||||||
|
{
|
||||||
|
public:
|
||||||
|
/** This constructor is used when registering the CheckObsoleteFunctions */
|
||||||
|
CheckObsoleteFunctions() : Check()
|
||||||
|
{ }
|
||||||
|
|
||||||
|
/** This constructor is used when running checks. */
|
||||||
|
CheckObsoleteFunctions(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
|
||||||
|
: Check(tokenizer, settings, errorLogger)
|
||||||
|
{ }
|
||||||
|
|
||||||
|
void runSimplifiedChecks(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
|
||||||
|
{
|
||||||
|
CheckObsoleteFunctions checkObsoleteFunctions(tokenizer, settings, errorLogger);
|
||||||
|
checkObsoleteFunctions.obsoleteFunctions();
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Check for obsolete functions */
|
||||||
|
void obsoleteFunctions();
|
||||||
|
|
||||||
|
private:
|
||||||
|
/** Report Error : Using obsolete function 'bsd_signal' */
|
||||||
|
void obsoleteFunctionbsd_signal(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'gethostbyaddr' */
|
||||||
|
void obsoleteFunctiongethostbyaddr(const Token*);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'gethostbyname' */
|
||||||
|
void obsoleteFunctiongethostbyname(const Token*);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'usleep' */
|
||||||
|
void obsoleteFunctionusleep(const Token*);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'bcmp' */
|
||||||
|
void obsoleteFunctionbcmp(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'bcopy' */
|
||||||
|
void obsoleteFunctionbcopy(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'bzero' */
|
||||||
|
void obsoleteFunctionbzero(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'ecvt' */
|
||||||
|
void obsoleteFunctionecvt(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'fcvt' */
|
||||||
|
void obsoleteFunctionfcvt(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'gcvt' */
|
||||||
|
void obsoleteFunctiongcvt(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'ftime' */
|
||||||
|
void obsoleteFunctionftime(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'getcontext' */
|
||||||
|
void obsoleteFunctiongetcontext(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'makecontext' */
|
||||||
|
void obsoleteFunctionmakecontext(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'swapcontext' */
|
||||||
|
void obsoleteFunctionswapcontext(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'getwd' */
|
||||||
|
void obsoleteFunctiongetwd(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'index' */
|
||||||
|
void obsoleteFunctionindex(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'pthread_attr_getstackaddr' */
|
||||||
|
void obsoleteFunctionpthread_attr_getstackaddr(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'pthread_attr_setstackaddr' */
|
||||||
|
void obsoleteFunctionpthread_attr_setstackaddr(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'rindex' */
|
||||||
|
void obsoleteFunctionrindex(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'scalb' */
|
||||||
|
void obsoleteFunctionscalb(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'ualarm' */
|
||||||
|
void obsoleteFunctionualarm(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'vfork' */
|
||||||
|
void obsoleteFunctionvfork(const Token *tok);
|
||||||
|
|
||||||
|
/** Report Error : Using obsolete function 'wcswcs' */
|
||||||
|
void obsoleteFunctionwcswcs(const Token *tok);
|
||||||
|
|
||||||
|
void getErrorMessages()
|
||||||
|
{
|
||||||
|
obsoleteFunctionbsd_signal(0);
|
||||||
|
obsoleteFunctiongethostbyaddr(0);
|
||||||
|
obsoleteFunctiongethostbyname(0);
|
||||||
|
obsoleteFunctionusleep(0);
|
||||||
|
obsoleteFunctionbcmp(0);
|
||||||
|
obsoleteFunctionbcopy(0);
|
||||||
|
obsoleteFunctionbzero(0);
|
||||||
|
obsoleteFunctionecvt(0);
|
||||||
|
obsoleteFunctionfcvt(0);
|
||||||
|
obsoleteFunctiongcvt(0);
|
||||||
|
obsoleteFunctionftime(0);
|
||||||
|
obsoleteFunctiongetcontext(0);
|
||||||
|
obsoleteFunctionmakecontext(0);
|
||||||
|
obsoleteFunctionswapcontext(0);
|
||||||
|
obsoleteFunctiongetwd(0);
|
||||||
|
obsoleteFunctionindex(0);
|
||||||
|
obsoleteFunctionpthread_attr_getstackaddr(0);
|
||||||
|
obsoleteFunctionpthread_attr_setstackaddr(0);
|
||||||
|
obsoleteFunctionrindex(0);
|
||||||
|
obsoleteFunctionscalb(0);
|
||||||
|
obsoleteFunctionualarm(0);
|
||||||
|
obsoleteFunctionvfork(0);
|
||||||
|
obsoleteFunctionwcswcs(0);
|
||||||
|
}
|
||||||
|
|
||||||
|
std::string name() const
|
||||||
|
{
|
||||||
|
return "Obsolete functions";
|
||||||
|
}
|
||||||
|
|
||||||
|
std::string classInfo() const
|
||||||
|
{
|
||||||
|
return "Warn if any of these obsolete functions are used:\n"
|
||||||
|
"* bsd_signal\n"
|
||||||
|
"* gethostbyaddr\n"
|
||||||
|
"* gethostbyname\n"
|
||||||
|
"* usleep\n"
|
||||||
|
"* bcmp\n"
|
||||||
|
"* bcopy\n"
|
||||||
|
"* bzero\n"
|
||||||
|
"* ecvt\n"
|
||||||
|
"* fcvt\n"
|
||||||
|
"* gcvt\n"
|
||||||
|
"* ftime\n"
|
||||||
|
"* getcontext\n"
|
||||||
|
"* makecontext\n"
|
||||||
|
"* swapcontext\n"
|
||||||
|
"* getwd\n"
|
||||||
|
"* index\n"
|
||||||
|
"* pthread_attr_getstackaddr\n"
|
||||||
|
"* pthread_attr_setstackaddr\n"
|
||||||
|
"* rindex\n"
|
||||||
|
"* scalb\n"
|
||||||
|
"* ualarm\n"
|
||||||
|
"* vfork\n"
|
||||||
|
"* wcswcs\n";
|
||||||
|
}
|
||||||
|
};
|
||||||
|
/// @}
|
||||||
|
//---------------------------------------------------------------------------
|
||||||
|
#endif
|
||||||
|
|
||||||
|
|
@ -7,6 +7,7 @@ HEADERS += $$PWD/check.h \
|
||||||
$$PWD/checkdangerousfunctions.h \
|
$$PWD/checkdangerousfunctions.h \
|
||||||
$$PWD/checkexceptionsafety.h \
|
$$PWD/checkexceptionsafety.h \
|
||||||
$$PWD/checkmemoryleak.h \
|
$$PWD/checkmemoryleak.h \
|
||||||
|
$$PWD/checkobsoletefunctions.h \
|
||||||
$$PWD/checkother.h \
|
$$PWD/checkother.h \
|
||||||
$$PWD/checkstl.h \
|
$$PWD/checkstl.h \
|
||||||
$$PWD/checkunusedfunctions.h \
|
$$PWD/checkunusedfunctions.h \
|
||||||
|
|
@ -29,6 +30,7 @@ SOURCES += $$PWD/checkautovariables.cpp \
|
||||||
$$PWD/checkdangerousfunctions.cpp \
|
$$PWD/checkdangerousfunctions.cpp \
|
||||||
$$PWD/checkexceptionsafety.cpp \
|
$$PWD/checkexceptionsafety.cpp \
|
||||||
$$PWD/checkmemoryleak.cpp \
|
$$PWD/checkmemoryleak.cpp \
|
||||||
|
$$PWD/checkobsoletefunctions.cpp \
|
||||||
$$PWD/checkother.cpp \
|
$$PWD/checkother.cpp \
|
||||||
$$PWD/checkstl.cpp \
|
$$PWD/checkstl.cpp \
|
||||||
$$PWD/checkunusedfunctions.cpp \
|
$$PWD/checkunusedfunctions.cpp \
|
||||||
|
|
|
||||||
|
|
@ -0,0 +1,188 @@
|
||||||
|
/*
|
||||||
|
* Cppcheck - A tool for static C/C++ code analysis
|
||||||
|
* Copyright (C) 2007-2010 Daniel Marjamäki and Cppcheck team.
|
||||||
|
*
|
||||||
|
* This program is free software: you can redistribute it and/or modify
|
||||||
|
* it under the terms of the GNU General Public License as published by
|
||||||
|
* the Free Software Foundation, either version 3 of the License, or
|
||||||
|
* (at your option) any later version.
|
||||||
|
*
|
||||||
|
* This program is distributed in the hope that it will be useful,
|
||||||
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
* GNU General Public License for more details.
|
||||||
|
*
|
||||||
|
* You should have received a copy of the GNU General Public License
|
||||||
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||||
|
*/
|
||||||
|
|
||||||
|
|
||||||
|
#include "tokenize.h"
|
||||||
|
#include "checkobsoletefunctions.h"
|
||||||
|
#include "testsuite.h"
|
||||||
|
|
||||||
|
#include <sstream>
|
||||||
|
|
||||||
|
extern std::ostringstream errout;
|
||||||
|
|
||||||
|
class TestObsoleteFunctions : public TestFixture
|
||||||
|
{
|
||||||
|
public:
|
||||||
|
TestObsoleteFunctions() : TestFixture("TestObsoleteFunctions")
|
||||||
|
{ }
|
||||||
|
|
||||||
|
private:
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
void check(const char code[])
|
||||||
|
{
|
||||||
|
// Tokenize..
|
||||||
|
Tokenizer tokenizer;
|
||||||
|
std::istringstream istr(code);
|
||||||
|
tokenizer.tokenize(istr, "test.cpp");
|
||||||
|
tokenizer.simplifyTokenList();
|
||||||
|
|
||||||
|
// Assign variable ids
|
||||||
|
tokenizer.setVarId();
|
||||||
|
|
||||||
|
// Fill function list
|
||||||
|
tokenizer.fillFunctionList();
|
||||||
|
|
||||||
|
// Clear the error buffer..
|
||||||
|
errout.str("");
|
||||||
|
|
||||||
|
// Check for obsolete functions..
|
||||||
|
Settings settings;
|
||||||
|
settings._checkCodingStyle = true;
|
||||||
|
settings.inconclusive = true;
|
||||||
|
CheckObsoleteFunctions checkObsoleteFunctions(&tokenizer, &settings, this);
|
||||||
|
checkObsoleteFunctions.obsoleteFunctions();
|
||||||
|
}
|
||||||
|
|
||||||
|
void run()
|
||||||
|
{
|
||||||
|
TEST_CASE(testbsd_signal);
|
||||||
|
TEST_CASE(testgethostbyname);
|
||||||
|
TEST_CASE(testgethostbyaddr);
|
||||||
|
TEST_CASE(testusleep);
|
||||||
|
TEST_CASE(testindex);
|
||||||
|
TEST_CASE(testrindex);
|
||||||
|
}
|
||||||
|
|
||||||
|
void testbsd_signal()
|
||||||
|
{
|
||||||
|
check("void f()\n"
|
||||||
|
"{\n"
|
||||||
|
" bsd_signal(SIGABRT, SIG_IGN);\n"
|
||||||
|
"}\n");
|
||||||
|
ASSERT_EQUALS("[test.cpp:3]: (style) Found obsolete function 'bsd_signal'. It is recommended that new applications use the 'sigaction' function\n", errout.str());
|
||||||
|
|
||||||
|
check("int f()\n"
|
||||||
|
"{\n"
|
||||||
|
" int bsd_signal(0);\n"
|
||||||
|
" return bsd_signal;\n"
|
||||||
|
"}\n");
|
||||||
|
ASSERT_EQUALS("", errout.str());
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
void testgethostbyname()
|
||||||
|
{
|
||||||
|
check("void f()\n"
|
||||||
|
"{\n"
|
||||||
|
" struct hostent *hp;\n"
|
||||||
|
" if(!hp = gethostbyname('127.0.0.1')) {\n"
|
||||||
|
" exit(1);\n"
|
||||||
|
" }\n"
|
||||||
|
"}\n");
|
||||||
|
ASSERT_EQUALS("[test.cpp:4]: (style) Found obsolete function 'gethostbyname'. It is recommended that new applications use the 'getnameinfo' function\n", errout.str());
|
||||||
|
}
|
||||||
|
|
||||||
|
void testgethostbyaddr()
|
||||||
|
{
|
||||||
|
check("void f()\n"
|
||||||
|
"{\n"
|
||||||
|
" long addr;\n"
|
||||||
|
" addr = inet_addr('127.0.0.1');\n"
|
||||||
|
" if(!hp = gethostbyaddr((char *) &addr, sizeof(addr), AF_INET)) {\n"
|
||||||
|
" exit(1);\n"
|
||||||
|
" }\n"
|
||||||
|
"}\n");
|
||||||
|
ASSERT_EQUALS("[test.cpp:5]: (style) Found obsolete function 'gethostbyaddr'. It is recommended that new applications use the 'getaddrinfo' function\n", errout.str());
|
||||||
|
}
|
||||||
|
|
||||||
|
void testusleep()
|
||||||
|
{
|
||||||
|
check("void f()\n"
|
||||||
|
"{\n"
|
||||||
|
" usleep( 1000 );\n"
|
||||||
|
"}\n");
|
||||||
|
ASSERT_EQUALS("[test.cpp:3]: (style) Found obsolete function 'usleep'. It is recommended that new applications use the 'nanosleep' or 'setitimer' function\n", errout.str());
|
||||||
|
}
|
||||||
|
|
||||||
|
void testindex()
|
||||||
|
{
|
||||||
|
|
||||||
|
check("namespace n1 {\n"
|
||||||
|
" int index(){};\n"
|
||||||
|
"}\n"
|
||||||
|
"int main()\n"
|
||||||
|
"{\n"
|
||||||
|
" n1::index();\n"
|
||||||
|
"}\n");
|
||||||
|
ASSERT_EQUALS("", errout.str());
|
||||||
|
|
||||||
|
check("std::size_t f()\n"
|
||||||
|
"{\n"
|
||||||
|
" std::size_t index(0);\n"
|
||||||
|
" index++;\n"
|
||||||
|
" return index;\n"
|
||||||
|
"}\n");
|
||||||
|
ASSERT_EQUALS("", errout.str());
|
||||||
|
|
||||||
|
check("int f()\n"
|
||||||
|
"{\n"
|
||||||
|
" return this->index();\n"
|
||||||
|
"}\n");
|
||||||
|
ASSERT_EQUALS("", errout.str());
|
||||||
|
|
||||||
|
check("void f()\n"
|
||||||
|
"{\n"
|
||||||
|
" int index( 0 );\n"
|
||||||
|
"}\n");
|
||||||
|
ASSERT_EQUALS("", errout.str());
|
||||||
|
|
||||||
|
check("const char f()\n"
|
||||||
|
"{\n"
|
||||||
|
" const char var[6] = 'index';\n"
|
||||||
|
" const char i = index(var, 0);\n"
|
||||||
|
" return i;\n"
|
||||||
|
"}\n");
|
||||||
|
ASSERT_EQUALS("[test.cpp:4]: (style) Found obsolete function 'index'. It is recommended to use the function 'strchr' instead\n", errout.str());
|
||||||
|
}
|
||||||
|
|
||||||
|
void testrindex()
|
||||||
|
{
|
||||||
|
check("void f()\n"
|
||||||
|
"{\n"
|
||||||
|
" int rindex( 0 );\n"
|
||||||
|
"}\n");
|
||||||
|
ASSERT_EQUALS("", errout.str());
|
||||||
|
|
||||||
|
check("void f()\n"
|
||||||
|
"{\n"
|
||||||
|
" const char var[7] = 'rindex';\n"
|
||||||
|
" print(rindex(var, 0));\n"
|
||||||
|
"}\n");
|
||||||
|
ASSERT_EQUALS("[test.cpp:4]: (style) Found obsolete function 'rindex'. It is recommended to use the function 'strrchr' instead\n", errout.str());
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
};
|
||||||
|
|
||||||
|
REGISTER_TEST(TestObsoleteFunctions)
|
||||||
|
|
||||||
|
|
||||||
Loading…
Reference in New Issue