walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Minor changes to gui code to silence repeated build warnings (#1872) 

Compile of gui would result in repeated warnings from two conditions:

1) gui/erroritem.h:104:30: warning: extra ‘;’ [-Wpedantic]
Message points to Qt Macro Q_DECLARE_METATYPE usage.
Semi Colon at EOL removed.

2) gui/resultstree.h:201:10: warning [-Woverloaded-virtual]
Message is indicating that function ResultsTree::selectionChanged
is being iterpreted as overloading function of the same name
in base clase (QTreeView::selectionChanged).
Refactored - function renamed to ResultsTree::treeSelectionChanged
This commit is contained in:
Scott Furry 2019-06-05 02:13:37 -06:00 committed by Daniel Marjamäki
parent c73d3930cc
commit a5c1884810
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gui/erroritem.h
View File

@ -101,7 +101,7 @@ public:
static bool sameCID(const ErrorItem &errorItem1, const ErrorItem &errorItem2); static bool sameCID(const ErrorItem &errorItem1, const ErrorItem &errorItem2);
}; };
Q_DECLARE_METATYPE(ErrorItem); Q_DECLARE_METATYPE(ErrorItem)
/** /**
* @brief A class containing error data for one shown error line. * @brief A class containing error data for one shown error line.

2
gui/resultstree.cpp
View File

@ -1363,5 +1363,5 @@ void ResultsTree::showInconclusiveColumn(bool show)
void ResultsTree::currentChanged(const QModelIndex &current, const QModelIndex &previous) void ResultsTree::currentChanged(const QModelIndex &current, const QModelIndex &previous)
{ {
QTreeView::currentChanged(current, previous); QTreeView::currentChanged(current, previous);
emit selectionChanged(current); emit treeSelectionChanged(current);
} }

2
gui/resultstree.h
View File

@ -198,7 +198,7 @@ signals:
* *
* @param current Model index to specify new selected item. * @param current Model index to specify new selected item.
*/ */
void selectionChanged(const QModelIndex &current); void treeSelectionChanged(const QModelIndex &current);
/** /**
* Selected item(s) has been tagged * Selected item(s) has been tagged

2
gui/resultsview.cpp
View File

@ -51,7 +51,7 @@ ResultsView::ResultsView(QWidget * parent) :
connect(mUI.mTree, &ResultsTree::resultsHidden, this, &ResultsView::resultsHidden); connect(mUI.mTree, &ResultsTree::resultsHidden, this, &ResultsView::resultsHidden);
connect(mUI.mTree, &ResultsTree::checkSelected, this, &ResultsView::checkSelected); connect(mUI.mTree, &ResultsTree::checkSelected, this, &ResultsView::checkSelected);
connect(mUI.mTree, &ResultsTree::selectionChanged, this, &ResultsView::updateDetails); connect(mUI.mTree, &ResultsTree::treeSelectionChanged, this, &ResultsView::updateDetails);
connect(mUI.mTree, &ResultsTree::tagged, this, &ResultsView::tagged); connect(mUI.mTree, &ResultsTree::tagged, this, &ResultsView::tagged);
connect(mUI.mTree, &ResultsTree::suppressIds, this, &ResultsView::suppressIds); connect(mUI.mTree, &ResultsTree::suppressIds, this, &ResultsView::suppressIds);
connect(this, &ResultsView::showResults, mUI.mTree, &ResultsTree::showResults); connect(this, &ResultsView::showResults, mUI.mTree, &ResultsTree::showResults);