walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Verification; Experimental checking for uninit

This commit is contained in:
Daniel Marjamäki 2019-12-30 18:55:16 +01:00
parent 33c8b71467
commit a60efa6774
3 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/exprengine.cpp
View File

@ -1698,6 +1698,20 @@ void ExprEngine::runChecks(ErrorLogger *errorLogger, const Tokenizer *tokenizer,
}; };
#endif #endif
#ifdef VERIFY_UNINIT // This is highly experimental
std::function<void(const Token *, const ExprEngine::Value &, ExprEngine::DataBase *)> uninit = [=](const Token *tok, const ExprEngine::Value &value, ExprEngine::DataBase *dataBase) {
if (!tok->astParent())
return;
if (!value.isUninit())
return;
dataBase->addError(tok->linenr());
std::list<const Token*> callstack{tok};
ErrorLogger::ErrorMessage errmsg(callstack, &tokenizer->list, Severity::SeverityType::error, "verificationUninit", "Cannot determine that data is initialized", CWE(908), false);
errorLogger->reportErr(errmsg);
};
#endif
std::function<void(const Token *, const ExprEngine::Value &, ExprEngine::DataBase *)> checkFunctionCall = [=](const Token *tok, const ExprEngine::Value &value, ExprEngine::DataBase *dataBase) { std::function<void(const Token *, const ExprEngine::Value &, ExprEngine::DataBase *)> checkFunctionCall = [=](const Token *tok, const ExprEngine::Value &value, ExprEngine::DataBase *dataBase) {
if (!Token::Match(tok->astParent(), "[(,]")) if (!Token::Match(tok->astParent(), "[(,]"))
return; return;
@ -1800,6 +1814,9 @@ void ExprEngine::runChecks(ErrorLogger *errorLogger, const Tokenizer *tokenizer,
#ifdef VERIFY_INTEGEROVERFLOW #ifdef VERIFY_INTEGEROVERFLOW
callbacks.push_back(integerOverflow); callbacks.push_back(integerOverflow);
#endif #endif
#ifdef VERIFY_UNINIT
callbacks.push_back(uninit);
#endif
std::ostringstream report; std::ostringstream report;
ExprEngine::executeAllFunctions(tokenizer, settings, callbacks, report); ExprEngine::executeAllFunctions(tokenizer, settings, callbacks, report);

6
lib/exprengine.h
View File

@ -105,6 +105,9 @@ namespace ExprEngine {
(void)value; (void)value;
return false; return false;
} }
virtual bool isUninit() const {
return false;
}
const std::string name; const std::string name;
ValueType type; ValueType type;
@ -113,6 +116,9 @@ namespace ExprEngine {
class UninitValue: public Value { class UninitValue: public Value {
public: public:
UninitValue() : Value("?", ValueType::UninitValue) {} UninitValue() : Value("?", ValueType::UninitValue) {}
bool isUninit() const OVERRIDE {
return true;
}
}; };
class IntRange : public Value { class IntRange : public Value {

7
test/testsuites/danmar-verify/uninit.c Normal file
View File

@ -0,0 +1,7 @@
void foo() {
int a[10];
a[0] = 0;
return a[2];
}