From a6b4cdb526ccc355f1e2d96c352799ff184528f9 Mon Sep 17 00:00:00 2001 From: Nicolas Le Cam Date: Sun, 7 Dec 2008 16:55:07 +0000 Subject: [PATCH] Constructors: Fix checking of 'operator=' with test --- CheckClass.cpp | 2 +- testconstructors.cpp | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/CheckClass.cpp b/CheckClass.cpp index edc30a81b..6a11531d4 100644 --- a/CheckClass.cpp +++ b/CheckClass.cpp @@ -429,7 +429,7 @@ void CheckClass::CheckConstructors(const TOKEN *tok1, struct VAR *varlist, const int indentlevel = 0; const TOKEN *constructor_token = FindClassFunction( tok1, className, funcname, indentlevel ); std::list callstack; - ClassChecking_VarList_Initialize(tok1, constructor_token, varlist, funcname, callstack); + ClassChecking_VarList_Initialize(tok1, constructor_token, varlist, className, callstack); while ( constructor_token ) { // Check if any variables are uninitialized diff --git a/testconstructors.cpp b/testconstructors.cpp index b08bdcf87..53a65a3fe 100644 --- a/testconstructors.cpp +++ b/testconstructors.cpp @@ -64,6 +64,7 @@ private: TEST_CASE( initvar_if ); // BUG 2190290 TEST_CASE( initvar_operator_eq1 ); // BUG 2190376 TEST_CASE( initvar_operator_eq2 ); // BUG 2190376 + TEST_CASE( initvar_operator_eq3 ); TEST_CASE( initvar_same_classname ); // BUG 2208157 TEST_CASE( initvar_chained_assign ); // BUG 2270433 TEST_CASE( initvar_2constructors ); // BUG 2270353 @@ -198,6 +199,19 @@ private: ASSERT_EQUALS( std::string("[test.cpp:5] Uninitialized member variable 'Fred::i'\n"), errout.str() ); } + void initvar_operator_eq3() + { + check( "class Fred\n" + "{\n" + "public:\n" + " Fred() { Init(); }\n" + " void operator=() { Init(); }\n" + "private:\n" + " Init() { i = 0; }\n" + " int i;\n" + "};\n" ); + ASSERT_EQUALS( std::string(""), errout.str() ); + } void initvar_same_classname() {