walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

cppcheckexecutor.cpp: fixed stack-use-after-scope reported by ASAN (#3018)

This commit is contained in:
Oliver Stöneberg 2021-01-06 11:39:24 +01:00 committed by GitHub
parent 9e4e06a524
commit a7f0e91539
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cli/cppcheckexecutor.cpp
View File

@ -278,6 +278,7 @@ static void print_stacktrace(FILE* output, bool demangling, int maxdepth, bool l
char **symbolStringList = backtrace_symbols(callstackArray, currentdepth); char **symbolStringList = backtrace_symbols(callstackArray, currentdepth);
if (symbolStringList) { if (symbolStringList) {
fputs("Callstack:\n", output); fputs("Callstack:\n", output);
char demangle_buffer[2048]= {0};
for (int i = offset; i < maxdepth; ++i) { for (int i = offset; i < maxdepth; ++i) {
const char * const symbolString = symbolStringList[i]; const char * const symbolString = symbolStringList[i];
char * realnameString = nullptr; char * realnameString = nullptr;
@ -292,12 +293,11 @@ static void print_stacktrace(FILE* output, bool demangling, int maxdepth, bool l
if (plus && (plus>(firstBracketName+1))) { if (plus && (plus>(firstBracketName+1))) {
char input_buffer[1024]= {0}; char input_buffer[1024]= {0};
strncpy(input_buffer, firstBracketName+1, plus-firstBracketName-1); strncpy(input_buffer, firstBracketName+1, plus-firstBracketName-1);
char output_buffer[2048]= {0}; size_t length = getArrayLength(demangle_buffer);
size_t length = getArrayLength(output_buffer);
int status=0; int status=0;
// We're violating the specification - passing stack address instead of malloc'ed heap. // We're violating the specification - passing stack address instead of malloc'ed heap.
// Benefit is that no further heap is required, while there is sufficient stack... // Benefit is that no further heap is required, while there is sufficient stack...
realnameString = abi::__cxa_demangle(input_buffer, output_buffer, &length, &status); // non-NULL on success realnameString = abi::__cxa_demangle(input_buffer, demangle_buffer, &length, &status); // non-NULL on success
} }
} }
const int ordinal=i-offset; const int ordinal=i-offset;