walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Restored functionality to detect std::string(0) calls as null pointer dereferences (#6189)

This commit is contained in:
PKEuS 2014-10-16 19:12:02 +02:00
parent 7107286be6
commit a99fd364ef
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checknullpointer.cpp
View File

@ -431,7 +431,7 @@ void CheckNullPointer::nullConstantDereference()
ovar = tok->variable(); ovar = tok->variable();
else if (Token::Match(tok, "%var% =|+ 0 )|]|,|;|+")) else if (Token::Match(tok, "%var% =|+ 0 )|]|,|;|+"))
ovar = tok->variable(); ovar = tok->variable();
if (ovar && !ovar->isPointer() && !ovar->isArray() && ovar->isStlStringType() && !tok->tokAt(2)->isLiteral()) if (ovar && !ovar->isPointer() && !ovar->isArray() && ovar->isStlStringType() && tok->tokAt(2)->originalName() != "'\\0'")
nullPointerError(tok); nullPointerError(tok);
} }
} }

2
test/testnullpointer.cpp
View File

@ -2026,6 +2026,8 @@ private:
"}", true); "}", true);
ASSERT_EQUALS("[test.cpp:9]: (error) Possible null pointer dereference: p\n" ASSERT_EQUALS("[test.cpp:9]: (error) Possible null pointer dereference: p\n"
"[test.cpp:10]: (error) Possible null pointer dereference: p\n" "[test.cpp:10]: (error) Possible null pointer dereference: p\n"
"[test.cpp:3]: (error) Null pointer dereference\n"
"[test.cpp:5]: (error) Null pointer dereference\n"
"[test.cpp:7]: (error) Null pointer dereference\n" "[test.cpp:7]: (error) Null pointer dereference\n"
"[test.cpp:8]: (error) Null pointer dereference\n" "[test.cpp:8]: (error) Null pointer dereference\n"
/* TODO: handle std::string /* TODO: handle std::string