walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fixed #10367 (False positive; pointer out of bounds argv-1)

This commit is contained in:
Daniel Marjamäki 2021-09-15 08:28:50 +02:00
parent 2d3b8d7003
commit a9a093e7cc
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/checkbufferoverrun.cpp
View File

@ -486,6 +486,9 @@ void CheckBufferOverrun::pointerArithmetic()
if (const ValueFlow::Value *neg = indexToken->getValueLE(-1, mSettings)) if (const ValueFlow::Value *neg = indexToken->getValueLE(-1, mSettings))
pointerArithmeticError(tok, indexToken, neg); pointerArithmeticError(tok, indexToken, neg);
} else if (tok->str() == "-") { } else if (tok->str() == "-") {
if (arrayToken->variable() && arrayToken->variable()->isArgument())
continue;
const Token *array = arrayToken; const Token *array = arrayToken;
while (Token::Match(array, ".|::")) while (Token::Match(array, ".|::"))
array = array->astOperand2(); array = array->astOperand2();

5
test/testbufferoverrun.cpp
View File

@ -3176,6 +3176,11 @@ private:
" dostuff(x-i);\n" " dostuff(x-i);\n"
"}"); "}");
TODO_ASSERT_EQUALS("[test.cpp:4]: (portability) Undefined behaviour, when 'i' is -20 the pointer arithmetic 'x-i' is out of bounds.\n", "", errout.str()); TODO_ASSERT_EQUALS("[test.cpp:4]: (portability) Undefined behaviour, when 'i' is -20 the pointer arithmetic 'x-i' is out of bounds.\n", "", errout.str());
check("void f(const char *x[10]) {\n"
" return x-4;\n"
"}");
ASSERT_EQUALS("", errout.str());
} }
void strcat1() { void strcat1() {