From aa3722feea5ee50217e1cb0d91c9279fe09258c9 Mon Sep 17 00:00:00 2001
From: Sebastian <versat@users.noreply.github.com>
Date: Thu, 17 May 2018 15:43:01 +0200
Subject: [PATCH] windows.cfg: Add lstrlen() configuration and tests. (#1239)

Reference: https://msdn.microsoft.com/en-us/library/windows/desktop/ms647492(v=vs.85).aspx
---
 cfg/windows.cfg      | 12 ++++++++++++
 test/cfg/windows.cpp |  9 +++++++++
 2 files changed, 21 insertions(+)

diff --git a/cfg/windows.cfg b/cfg/windows.cfg
index d1d03b8c6..551b5c1a1 100644
--- a/cfg/windows.cfg
+++ b/cfg/windows.cfg
@@ -4220,6 +4220,18 @@ HFONT CreateFont(
       <strz/>
     </arg>
   </function>
+  <!-- int WINAPI lstrlen(_In_ LPCTSTR lpString); -->
+  <function name="lstrlen,lstrlenA,lstrlenW">
+    <use-retval/>
+    <returnValue type="int"/>
+    <noreturn>false</noreturn>
+    <leak-ignore/>
+    <warn severity="style" alternatives="StringCbLength,StringCchLength">Due to security concerns it is not recommended to use this function, see MSDN for details.</warn>
+    <arg nr="1">
+      <not-uninit/>
+      <strz/>
+    </arg>
+  </function>
   <!--HANDLE WINAPI CreateSemaphore(
   _In_opt_ LPSECURITY_ATTRIBUTES lpSemaphoreAttributes,
   _In_     LONG                  lInitialCount,
diff --git a/test/cfg/windows.cpp b/test/cfg/windows.cpp
index b48d2a0b1..97ff96849 100644
--- a/test/cfg/windows.cpp
+++ b/test/cfg/windows.cpp
@@ -163,6 +163,11 @@ void validCode()
     HLOCAL pLocalAlloc = LocalAlloc(1, 2);
     LocalFree(pLocalAlloc);
 
+    // cppcheck-suppress lstrlenCalled
+    (void)lstrlen(bufTC);
+    // cppcheck-suppress lstrlenCalled
+    (void)lstrlen(NULL);
+
     // Intrinsics
     __noop();
     __noop(1, "test", NULL);
@@ -485,6 +490,10 @@ void ignoredReturnValue()
 
     // cppcheck-suppress ignoredReturnValue
     _fileno(stdio);
+
+    // cppcheck-suppress lstrlenCalled
+    // cppcheck-suppress ignoredReturnValue
+    lstrlen(TEXT("test"));
 }
 
 void invalidFunctionArg()