walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Uninitialized variables: Fixed simple undetected case for '= %var% |' and '| %var% ;'

This commit is contained in:
Daniel Marjamäki 2010-11-16 20:16:44 +01:00
parent eb54be2b2a
commit aa653fe42b
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/checkuninitvar.cpp
View File

@ -465,7 +465,7 @@ private:
} }
// Used.. // Used..
if (Token::Match(tok.previous(), "[[(,+-*/=] %var% []),;+-*/]")) if (Token::Match(tok.previous(), "[[(,+-*/|=] %var% []),;+-*/|]"))
{ {
use(checks, &tok); use(checks, &tok);
return &tok; return &tok;

17
test/testuninitvar.cpp
View File

@ -35,6 +35,7 @@ private:
void run() void run()
{ {
TEST_CASE(uninitvar1); TEST_CASE(uninitvar1);
TEST_CASE(uninitvar_bitop); // using uninitialized operand in bit operation
TEST_CASE(uninitvar_alloc); // data is allocated but not initialized TEST_CASE(uninitvar_alloc); // data is allocated but not initialized
TEST_CASE(uninitvar_arrays); // arrays TEST_CASE(uninitvar_arrays); // arrays
TEST_CASE(uninitvar_class); // class/struct TEST_CASE(uninitvar_class); // class/struct
@ -450,6 +451,22 @@ private:
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void uninitvar_bitop()
{
checkUninitVar("void foo() {\n"
" int b;\n"
" c = a | b;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: b\n", errout.str());
checkUninitVar("void foo() {\n"
" int b;\n"
" c = b | a;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3]: (error) Uninitialized variable: b\n", errout.str());
}
// if.. // if..
void uninitvar_if() void uninitvar_if()
{ {