walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Rewrite CheckBool::checkAssignBoolToPointer to use ValueType

This commit is contained in:
Daniel Marjamäki 2019-03-09 19:15:06 +01:00
parent e17ddfd964
commit ac42382cd9
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/checkbool.cpp
View File

@ -293,15 +293,16 @@ void CheckBool::checkAssignBoolToPointer()
const SymbolDatabase *symbolDatabase = mTokenizer->getSymbolDatabase();
for (const Scope * scope : symbolDatabase->functionScopes) {
for (const Token* tok = scope->bodyStart; tok != scope->bodyEnd; tok = tok->next()) {
if (tok->str() == "=" && astIsBool(tok->astOperand2())) {
const Token *lhs = tok->astOperand1();
while (lhs && (lhs->str() == "." || lhs->str() == "::"))
lhs = lhs->astOperand2();
if (!lhs || !lhs->variable() || !lhs->variable()->isPointer())
continue;
if (tok->str() != "=")
continue;
const ValueType *lhsType = tok->astOperand1() ? tok->astOperand1()->valueType() : nullptr;
if (!lhsType || lhsType->pointer == 0)
continue;
const ValueType *rhsType = tok->astOperand2() ? tok->astOperand2()->valueType() : nullptr;
if (!rhsType || rhsType->pointer > 0 || rhsType->type != ValueType::Type::BOOL)
continue;
assignBoolToPointerError(tok);
}
assignBoolToPointerError(tok);
}
}
}