walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Bug hunting; avoid bughuntingUninitVar fp for template variable

This commit is contained in:
Daniel Marjamäki 2020-09-07 16:25:37 +02:00
parent 0c6dc84cbb
commit acfff072ae
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/bughuntingchecks.cpp
View File

@ -251,6 +251,10 @@ static void uninit(const Token *tok, const ExprEngine::Value &value, ExprEngine:
if (tok->variable() && !tok->variable()->isPointer() && tok->variable()->isSmartPointer()) if (tok->variable() && !tok->variable()->isPointer() && tok->variable()->isSmartPointer())
return; return;
// template variable is not uninitialized
if (tok->variable() && !tok->variable()->isPointer() && Token::findmatch(tok->variable()->typeStartToken(), "%name% <", tok->variable()->typeEndToken()))
return;
// lhs in assignment // lhs in assignment
if (tok->astParent()->str() == "=" && tok == tok->astParent()->astOperand1()) if (tok->astParent()->str() == "=" && tok == tok->astParent()->astOperand1())
return; return;

10
test/testbughuntingchecks.cpp
View File

@ -43,6 +43,7 @@ private:
TEST_CASE(uninit_struct); TEST_CASE(uninit_struct);
TEST_CASE(uninit_bailout); TEST_CASE(uninit_bailout);
TEST_CASE(uninit_fp_try_smartptr); TEST_CASE(uninit_fp_try_smartptr);
TEST_CASE(uninit_fp_template_var);
TEST_CASE(ctu); TEST_CASE(ctu);
#endif #endif
} }
@ -185,6 +186,15 @@ private:
"}"); "}");
ASSERT_EQUALS("", errout.str()); ASSERT_EQUALS("", errout.str());
} }
void uninit_fp_template_var() {
check("void foo() {\n"
" X*x = DYNAMIC_CAST(X, p);\n"
" C<int> c;\n"
" f(c);\n"
"}");
ASSERT_EQUALS("", errout.str());
}
}; };
REGISTER_TEST(TestBughuntingChecks) REGISTER_TEST(TestBughuntingChecks)